[Discover] Use summary column service name component for service name… #196742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedhamed-ahmed
added
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
mohamedhamed-ahmed
added
the
backport:skip
mohamedhamed-ahmed
added
backport:version
ryankeairns
reviewed
Oct 21, 2024
| agentName={agentName} | ||
| size="m" | ||
| css={css` | ||
| margin-right: ${euiThemeVars.euiSizeXS}; |
There was a problem hiding this comment.
I see this but also see the icon bring right up against the text. Is this what this line is aiming to avoid or do we need to add margin here too? (see image)
There was a problem hiding this comment.
@ryankeairns is the image taken from the video? because I guess the video was before the fix of applying the styles
There was a problem hiding this comment.
Nit: since these styles are the same across instances, declaring them as a constant outside of the component would be more performant. I usually wouldn't recommend such a micro optimization, but it's worth considering since performance can be very sensitive within grid cells where we render so many at once.
davismcphee
added
the
Project:OneDiscover
davismcphee
approved these changes
Oct 21, 2024
| agentName={agentName} | ||
| size="m" | ||
| css={css` | ||
| margin-right: ${euiThemeVars.euiSizeXS}; |
There was a problem hiding this comment.
Nit: since these styles are the same across instances, declaring them as a constant outside of the component would be more performant. I usually wouldn't recommend such a micro optimization, but it's worth considering since performance can be very sensitive within grid cells where we render so many at once.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
elastic#196742) closes elastic#196541 ## 📝 Summary This PR updated the `service.name` cell renderer so that it mimics what we have in the `summary` column. It now shows a clickable pill shape for quick filters and navigating to the service page if `APM` is available. ## 🎥 Demo https://github.com/user-attachments/assets/627b39af-f008-487b-82f2-c0ab79aff9a4 (cherry picked from commit 3130492)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 22, 2024
…e name… (#196742) (#197228) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Use summary column service name component for service name… (#196742)](#196742) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"mohamedhamed-ahmed","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T12:33:20Z","message":"[Discover] Use summary column service name component for service name… (#196742)\n\ncloses https://github.com/elastic/kibana/issues/196541\r\n## 📝 Summary\r\n\r\nThis PR updated the `service.name` cell renderer so that it mimics what\r\nwe have in the `summary` column.\r\nIt now shows a clickable pill shape for quick filters and navigating to\r\nthe service page if `APM` is available.\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/627b39af-f008-487b-82f2-c0ab79aff9a4","sha":"3130492752b622458d521eec228e075916237d74","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","Team:obs-ux-logs","Project:OneDiscover","backport:version","v8.17.0"],"title":"[Discover] Use summary column service name component for service name…","number":196742,"url":"https://github.com/elastic/kibana/pull/196742","mergeCommit":{"message":"[Discover] Use summary column service name component for service name… (#196742)\n\ncloses https://github.com/elastic/kibana/issues/196541\r\n## 📝 Summary\r\n\r\nThis PR updated the `service.name` cell renderer so that it mimics what\r\nwe have in the `summary` column.\r\nIt now shows a clickable pill shape for quick filters and navigating to\r\nthe service page if `APM` is available.\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/627b39af-f008-487b-82f2-c0ab79aff9a4","sha":"3130492752b622458d521eec228e075916237d74"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196742","number":196742,"mergeCommit":{"message":"[Discover] Use summary column service name component for service name… (#196742)\n\ncloses https://github.com/elastic/kibana/issues/196541\r\n## 📝 Summary\r\n\r\nThis PR updated the `service.name` cell renderer so that it mimics what\r\nwe have in the `summary` column.\r\nIt now shows a clickable pill shape for quick filters and navigating to\r\nthe service page if `APM` is available.\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/627b39af-f008-487b-82f2-c0ab79aff9a4","sha":"3130492752b622458d521eec228e075916237d74"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: mohamedhamed-ahmed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #196541
📝 Summary
This PR updated the
service.namecell renderer so that it mimics what we have in thesummarycolumn.It now shows a clickable pill shape for quick filters and navigating to the service page if
APMis available.🎥 Demo
Screen.Recording.2024-10-17.at.14.38.59.mov