[8.16] [React@18 failing test] Navigate to dataset details should navigate to details page from a main page. (#196384) #196739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o details page from a main page. (elastic#196384) ## Summary Hi team, we're working on upgrading Kibana to React@18 in legacy mode elastic/kibana-team#1016 (comment) and addressing remaining functional tests when running with React@18 in Legacy Mode. One failure we've found is happening on the dataset quality page: navigate to dataset details should navigate to details page from a main page. [Failure](https://buildkite.com/elastic/kibana-pull-request/builds/236562#019222ec-e95e-44aa-a754-fd9f736accce). I tracked it down to infinite re-render of `DegradedDocs` component. Looks like there is an infinite useEffect loop that is also happening with react@17, but the results of it are not so severe so the tests are still passing and the page is still functioning with react@17, wheres with react@18 it becomes completely unresponsive. This effect causes the inifite loop because `breakdown` is new object with each render: https://github.com/elastic/kibana/blob/0d19367fdfad5526b5220dfdf18b4991fe6b3abd/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality_details/overview/document_trends/degraded_docs/index.tsx#L85-L91 To reproduce the loop, I used the setup from the following functional tests suite: x-pack/test/functional/apps/dataset_quality/dataset_quality_details.ts (cherry picked from commit 6f4346e)
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.16:Questions ?
Please refer to the Backport tool documentation