[FTR][Ownership] Features, File Upload, Grok Dbgr, Stats & Kql Telem #196709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigned features due to elastic#35841 Assigned file_upload due to https://github.com/elastic/kibana/blob/c79f0ae78633c81beebd3f95735326cc872be7f6/x-pack/plugins/file_upload/kibana.jsonc#L4 Assigned grok debugger due to https://github.com/elastic/kibana/blob/c79f0ae78633c81beebd3f95735326cc872be7f6/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned stats due to https://github.com/elastic/kibana/blob/c79f0ae78633c81beebd3f95735326cc872be7f6/src/plugins/usage_collection/kibana.jsonc#L4 - and I found the GET route within `src/plugins/usage_collection/server/routes/stats/stats.ts` Assigned kql_telemetry due to https://github.com/elastic/kibana/blob/3bfa7c00181599541c924d36b593205fd5d9fed4/src/plugins/data/kibana.jsonc#L4 - the service is exposed here: `src/plugins/data/server/kql_telemetry/kql_telemetry_service.ts` Contributes to: elastic#194817
wayneseymour
added
release_note:skip
wayneseymour
changed the title
jughosta
approved these changes
Oct 17, 2024
elena-shostak
approved these changes
Oct 17, 2024
Heenawter
approved these changes
Oct 17, 2024
markov00
approved these changes
Oct 17, 2024
.github/CODEOWNERS
Outdated
| @@ -1258,6 +1259,7 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai | |||
| ### END Observability Plugins | |||
|
|
|||
| # Presentation | |||
| /x-pack/test/api_integration/apis/file_upload @elastic/kibana-presentation @elastic/ml-ui | |||
There was a problem hiding this comment.
@Heenawter do the kibana-presentation team need to be co-owners of these API test files? I think all these tests are on the functionality added by ML. If not, @wayneseymour I'd suggest you make @elastic/ml-ui the sole owner and move this line into the Machine Learning section.
There was a problem hiding this comment.
That's fine with me! :) cc @nreese
💚 Build Succeeded
Metrics [docs]
History
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assign ownership to some files that hopefully result in less than 5 reviewers
Assignment Reasons
Assigned features due to #35841
Assigned file_upload due to
kibana/x-pack/plugins/file_upload/kibana.jsonc
Line 4 in c79f0ae
Assigned grok debugger due to
kibana/x-pack/plugins/grokdebugger/kibana.jsonc
Line 4 in c79f0ae
Assigned stats due to
kibana/src/plugins/usage_collection/kibana.jsonc
Line 4 in c79f0ae
src/plugins/usage_collection/server/routes/stats/stats.tsAssigned kql_telemetry due to
kibana/src/plugins/data/kibana.jsonc
Line 4 in 3bfa7c0
src/plugins/data/server/kql_telemetry/kql_telemetry_service.tsContributes to: #194817