Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQL] resolve issue with incomplete string escaping #196678

Merged
merged 3 commits into from
Oct 21, 2024
Merged

[CodeQL] resolve issue with incomplete string escaping #196678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca4412b
resolve issue with incomplete string escaping
eokoneyo Oct 17, 2024
5adfcdf
Merge branch 'main' into chore/resolve-codeql-scan-incomplete-string-…
elasticmachine Oct 17, 2024
f00763d
Merge branch 'main' into chore/resolve-codeql-scan-incomplete-string-…
elasticmachine Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-monaco/scripts/utils/create_autocomplete_definitions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const getDisplayName = (name, imported) => {
displayName = name.split('.').pop() || name;
}

return displayName.replace('$', '.');
return displayName.replace(/^\$/g, '.');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched this for a regex that only matches the beginning, because of the comment here

};

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-monaco/src/painless/worker/painless_worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class PainlessWorker implements BaseWorkerDefinition {
fields?: PainlessAutocompleteField[]
): PainlessCompletionResult {
// Array of the active line words, e.g., [boolean, isTrue, =, true]
const words = currentLineChars.replace('\t', '').split(' ');
const words = currentLineChars.replace(/\t/g, '').split(/\s/);

const autocompleteSuggestions: PainlessCompletionResult = getAutocompleteSuggestions(
context,
Expand Down