Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing "Fixes" to "Fixed by" in the user-facing view of the Vulnerability flyout #196669

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

2div
Copy link
Contributor

@2div 2div commented Oct 17, 2024

Summary

Changing "Fixes" to "Fixed by" in the user-facing view of the Vulnerability flyout

image

Hi @maxcold Please review my PR.

Thank you

@2div 2div requested a review from a team as a code owner October 17, 2024 11:22
Copy link

cla-checker-service bot commented Oct 17, 2024

💚 CLA has been signed

@maxcold maxcold added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) 8.17 candidate Team:Cloud Security Cloud Security team related labels Oct 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@maxcold maxcold added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.17.0 and removed 8.17 candidate labels Oct 17, 2024
@maxcold
Copy link
Contributor

maxcold commented Oct 17, 2024

hi @2div , thanks for the contribution! Can you also check this comment #196669 (comment) and sign the Contribution Agreement?

@2div
Copy link
Contributor Author

2div commented Oct 17, 2024

hi @2div , thanks for the contribution! Can you also check this comment #196669 (comment) and sign the Contribution Agreement?

Hi @maxcold , I signed the Contribution Agreement.

@opauloh
Copy link
Contributor

opauloh commented Oct 17, 2024

/ci

@opauloh
Copy link
Contributor

opauloh commented Oct 17, 2024

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 508.7KB 508.7KB +3.0B

History

@opauloh
Copy link
Contributor

opauloh commented Oct 17, 2024

@elasticmachine run docs-build

@maxcold maxcold merged commit a6c0ed1 into elastic:main Oct 18, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11401127543

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
…bility flyout (elastic#196669)

## Summary

Changing "Fixes" to "Fixed by" in the user-facing view of the
Vulnerability flyout

![image](https://github.com/user-attachments/assets/e06bf5a2-7751-46de-b935-d221ac7c9e09)

Hi @maxcold  Please review my PR.

Thank you

- fixes elastic#195965

Co-authored-by: Paulo Silva <[email protected]>
(cherry picked from commit a6c0ed1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 18, 2024
…facing view of the Vulnerability flyout (#196669) (#196826)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Changing &quot;Fixes&quot; to &quot;Fixed by&quot; in the user-facing
view of the Vulnerability flyout
(#196669)](#196669)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"mdiv.io","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T09:26:42Z","message":"Changing
\"Fixes\" to \"Fixed by\" in the user-facing view of the Vulnerability
flyout (#196669)\n\n## Summary\r\n\r\nChanging \"Fixes\" to \"Fixed by\"
in the user-facing view of the\r\nVulnerability
flyout\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/e06bf5a2-7751-46de-b935-d221ac7c9e09)\r\n\r\nHi
@maxcold Please review my PR.\r\n\r\nThank you\r\n\r\n- fixes
https://github.com/elastic/kibana/issues/195965\r\n\r\nCo-authored-by:
Paulo Silva
<[email protected]>","sha":"a6c0ed165e6aa7df49a1bdd18669dbde644bbd1e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","💝community","v9.0.0","Team:Cloud
Security","backport:prev-minor","v8.17.0"],"title":"Changing \"Fixes\"
to \"Fixed by\" in the user-facing view of the Vulnerability
flyout","number":196669,"url":"https://github.com/elastic/kibana/pull/196669","mergeCommit":{"message":"Changing
\"Fixes\" to \"Fixed by\" in the user-facing view of the Vulnerability
flyout (#196669)\n\n## Summary\r\n\r\nChanging \"Fixes\" to \"Fixed by\"
in the user-facing view of the\r\nVulnerability
flyout\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/e06bf5a2-7751-46de-b935-d221ac7c9e09)\r\n\r\nHi
@maxcold Please review my PR.\r\n\r\nThank you\r\n\r\n- fixes
https://github.com/elastic/kibana/issues/195965\r\n\r\nCo-authored-by:
Paulo Silva
<[email protected]>","sha":"a6c0ed165e6aa7df49a1bdd18669dbde644bbd1e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196669","number":196669,"mergeCommit":{"message":"Changing
\"Fixes\" to \"Fixed by\" in the user-facing view of the Vulnerability
flyout (#196669)\n\n## Summary\r\n\r\nChanging \"Fixes\" to \"Fixed by\"
in the user-facing view of the\r\nVulnerability
flyout\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/e06bf5a2-7751-46de-b935-d221ac7c9e09)\r\n\r\nHi
@maxcold Please review my PR.\r\n\r\nThank you\r\n\r\n- fixes
https://github.com/elastic/kibana/issues/195965\r\n\r\nCo-authored-by:
Paulo Silva
<[email protected]>","sha":"a6c0ed165e6aa7df49a1bdd18669dbde644bbd1e"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: mdiv.io <[email protected]>
@opauloh
Copy link
Contributor

opauloh commented Oct 18, 2024

The PR successfully passed the CI and it was merged, thanks for your contribution @2div

@2div
Copy link
Contributor Author

2div commented Oct 18, 2024

The PR successfully passed the CI and it was merged, thanks for your contribution @2div

@opauloh I appreciate you assigning this task to me and allowing me to be a part of the Kibana project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Fixes" copy should be more explanatory
5 participants