Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] unskip search details page tests #196638

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

joemcelroy
Copy link
Member

@joemcelroy joemcelroy commented Oct 17, 2024

Summary

Skip only the search detail api tests

Checklist

Delete any items that are not applicable to this PR.

@joemcelroy joemcelroy requested a review from a team as a code owner October 17, 2024 08:28
@joemcelroy joemcelroy changed the title unskip search details page tests [Search] unskip search details page tests Oct 17, 2024
@joemcelroy joemcelroy added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Search release_note:skip Skip the PR/issue when compiling release notes labels Oct 17, 2024
@joemcelroy
Copy link
Member Author

related to #194704

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7158

[✅] x-pack/test_serverless/api_integration/test_suites/search/config.feature_flags.ts: 25/25 tests passed.

see run history

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / FileAttachmentEvent renders clickable name

@joemcelroy
Copy link
Member Author

@elasticmachine merge upstream

@joemcelroy joemcelroy merged commit 05d9b5c into elastic:main Oct 17, 2024
24 checks passed
@joemcelroy joemcelroy deleted the unskip-detail-page-tests branch October 17, 2024 13:02
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11385510121

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
## Summary

Skip only the search detail api tests

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 05d9b5c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 17, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] unskip search details page tests
(#196638)](#196638)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joe
McElroy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T13:02:42Z","message":"[Search]
unskip search details page tests (#196638)\n\n## Summary\r\n\r\nSkip
only the search detail api tests \r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"05d9b5c088415f83a2496c3c24e9b0e7e8501981","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[Search]
unskip search details page
tests","number":196638,"url":"https://github.com/elastic/kibana/pull/196638","mergeCommit":{"message":"[Search]
unskip search details page tests (#196638)\n\n## Summary\r\n\r\nSkip
only the search detail api tests \r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"05d9b5c088415f83a2496c3c24e9b0e7e8501981"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196638","number":196638,"mergeCommit":{"message":"[Search]
unskip search details page tests (#196638)\n\n## Summary\r\n\r\nSkip
only the search detail api tests \r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"05d9b5c088415f83a2496c3c24e9b0e7e8501981"}}]}]
BACKPORT-->

Co-authored-by: Joe McElroy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants