Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Repurpose attack discover tour into knowledge base tour #196615

Merged
merged 16 commits into from
Oct 23, 2024
Merged

[Security Solution] Repurpose attack discover tour into knowledge base tour #196615

merged 16 commits into from
Oct 23, 2024

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 16, 2024 •
edited by kibanamachine
Loading

Summary

Resolves #182855

Removes attack discovery tour
Adds knowledge base entry tour

Screenshot 2024-10-16 at 3 45 51 PM Screenshot 2024-10-16 at 3 45 10 PM

To do before merging

Opened early to gather enough reviews to make it in time for BC2.

  1. Update copy 5cdd3e6
  2. Update video - uses the attack discovery video as a placeholder. I might merge with this if I do not have the video in time for BC2, but the video must be updated before removing the assistantKnowledgeBaseByDefault feature flag. I added a comment in the code to make sure this is addressed.

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Security Generative AI Security Generative AI v8.16.0 labels Oct 16, 2024
stephmilovic
stephmilovic commented Oct 16, 2024
View reviewed changes
x-pack/plugins/osquery/cypress/tasks/navigation.ts
@@ -47,7 +47,7 @@ export const NEW_FEATURES_TOUR_STORAGE_KEYS = {
TIMELINES: 'securitySolution.security.timelineFlyoutHeader.saveTimelineTour',
TIMELINE: 'securitySolution.timeline.newFeaturesTour.v8.12',
FLYOUT: 'securitySolution.documentDetails.newFeaturesTour.v8.14',
ATTACK_DISCOVERY: 'securitySolution.attackDiscovery.newFeaturesTour.v8.14',
KNOWLEDGE_BASE: 'elasticAssistant.knowledgeBase.newFeaturesTour.v8.16',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this tour will interfere with your tests since I have the const isTestAutomation = window.Cypress != null; logic in the tour component now, but it does not hurt to have it here.

@stephmilovic stephmilovic marked this pull request as ready for review October 22, 2024 19:07
@stephmilovic stephmilovic requested review from a team as code owners October 22, 2024 19:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@jamesspi
Copy link

@stephmilovic , here's the copy text to use:

  • Step 1 Title: New: Custom Knowledge Sources

  • Step 1 Description: Access the new settings menu to add custom data sources for use within the AI Assistant

  • Step 2 Title: Introducing Custom Knowledge Sources

  • Step 2 Description: Custom knowledge sources enable you to receive bespoke, tailored responses from the AI Assistant. Watch this video to learn how to add your own data sources and explore examples of how they can be applied in a security operations context.

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

semd
semd approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the cleaning ❤️

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationAssistant 459 465 +6
securitySolution 6041 6042 +1
total +7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/security-solution-side-nav 24 23 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB -75.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 87.6KB 87.6KB -74.0B
Unknown metric groups

API count

id before after diff
@kbn/security-solution-side-nav 30 29 -1

miscellaneous assets size

id before after diff
integrationAssistant 250.8KB 1.9MB ⚠️ +1.7MB

History

@stephmilovic stephmilovic merged commit fa9bb19 into elastic:main Oct 23, 2024
47 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11488089553

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
@stephmilovic
[Security Solution] Repurpose attack discover tour into knowledge bas…
684fdc5 
…e tour (elastic#196615)

(cherry picked from commit fa9bb19)
@kibanamachine kibanamachine mentioned this pull request Oct 23, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
@stephmilovic
[Security Solution] Repurpose attack discover tour into knowledge bas…
ec438df 
…e tour (elastic#196615)

(cherry picked from commit fa9bb19)
@kibanamachine kibanamachine mentioned this pull request Oct 23, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 23, 2024
@kibanamachine @stephmilovic
[8.x] [Security Solution] Repurpose attack discover tour into knowled…
7068760 
…ge base tour (#196615) (#197536)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Repurpose attack discover tour into knowledge
base tour (#196615)](#196615)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T21:02:35Z","message":"[Security
Solution] Repurpose attack discover tour into knowledge base tour
(#196615)","sha":"fa9bb19f14648bbe34493481df0b32838d0e5734","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Security Generative
AI","v8.16.0"],"title":"[Security Solution] Repurpose attack discover
tour into knowledge base
tour","number":196615,"url":"https://github.com/elastic/kibana/pull/196615","mergeCommit":{"message":"[Security
Solution] Repurpose attack discover tour into knowledge base tour
(#196615)","sha":"fa9bb19f14648bbe34493481df0b32838d0e5734"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196615","number":196615,"mergeCommit":{"message":"[Security
Solution] Repurpose attack discover tour into knowledge base tour
(#196615)","sha":"fa9bb19f14648bbe34493481df0b32838d0e5734"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 23, 2024
@kibanamachine @stephmilovic @elasticmachine
[8.16] [Security Solution] Repurpose attack discover tour into knowle…
a8d1c24 
…dge base tour (#196615) (#197535)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution] Repurpose attack discover tour into knowledge
base tour (#196615)](#196615)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T21:02:35Z","message":"[Security
Solution] Repurpose attack discover tour into knowledge base tour
(#196615)","sha":"fa9bb19f14648bbe34493481df0b32838d0e5734","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Security Generative
AI","v8.16.0"],"title":"[Security Solution] Repurpose attack discover
tour into knowledge base
tour","number":196615,"url":"https://github.com/elastic/kibana/pull/196615","mergeCommit":{"message":"[Security
Solution] Repurpose attack discover tour into knowledge base tour
(#196615)","sha":"fa9bb19f14648bbe34493481df0b32838d0e5734"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196615","number":196615,"mergeCommit":{"message":"[Security
Solution] Repurpose attack discover tour into knowledge base tour
(#196615)","sha":"fa9bb19f14648bbe34493481df0b32838d0e5734"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl is a code owner automatically assigned from elastic/security-defend-workflows

@szwarckonrad szwarckonrad Awaiting requested review from szwarckonrad szwarckonrad is a code owner automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Remove Attack discovery tour in 8.16
6 participants
@stephmilovic @elasticmachine @jamesspi @kibanamachine @patrykkopycinski @semd