Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Synthetic] Show monitors from all permitted spaces !! (#196109) #196596

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Fixes elastic#194760 !!
Fixes elastic#169753 !!

Added an options to list monitors from all spaces which user has
permission for , user can either select default option which is to get
monitors from current space or all permitted spaces !!

### Testing

Create monitors in 3 spaces, assign 2 spaces to a role, and create a
user. Make sure monitors only appears to which user have space
permission.

<img width="1727" alt="image"
src="https://github.com/user-attachments/assets/972d213a-ee00-4950-be9f-a209393cb69a">

---------

Co-authored-by: Justin Kambic <[email protected]>
(cherry picked from commit 2f67874)
@kibanamachine kibanamachine enabled auto-merge (squash) October 16, 2024 19:13
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibanamachine kibanamachine merged commit 2c833fd into elastic:8.x Oct 16, 2024
30 of 31 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / DeleteAttachmentConfirmationModal calls onConfirm

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1153 1154 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +4.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 37.1KB 37.6KB +493.0B

cc @shahzad31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants