[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci #196591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapral18
added
backport:prev-minor
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
PhilippeOberti
approved these changes
Oct 17, 2024
kqualters-elastic
approved these changes
Oct 18, 2024
kapral18
force-pushed
the
fix/DQD/fix-flaky-tests
branch
from
0b199da to
cfc2c6c
Compare
…ests timing out on ci addresses elastic#196216
- Refactored test cases to use `data-test-subj` attributes for 10x faster element selection - Added missing `data-test-subj` attributes in components to facilitate the prev point
kapral18
force-pushed
the
fix/DQD/fix-flaky-tests
branch
from
839fb35 to
9f63b9b
Compare
semd
approved these changes
Oct 31, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @kapral18 |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2024
…ests timing out on ci (elastic#196591) addresses elastic#196216 Removing accessibility selectors to ensure 10x speed of tests with data-test-subj locators. (cherry picked from commit b5a705e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2024
…tial tests timing out on ci (#196591) (#198717) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591)](#196591) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T18:59:41Z","message":"[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591)\n\naddresses #196216\r\n\r\nRemoving accessibility selectors to ensure 10x speed of tests with\r\ndata-test-subj locators.","sha":"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:prev-minor"],"title":"[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci","number":196591,"url":"https://github.com/elastic/kibana/pull/196591","mergeCommit":{"message":"[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591)\n\naddresses #196216\r\n\r\nRemoving accessibility selectors to ensure 10x speed of tests with\r\ndata-test-subj locators.","sha":"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196591","number":196591,"mergeCommit":{"message":"[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591)\n\naddresses #196216\r\n\r\nRemoving accessibility selectors to ensure 10x speed of tests with\r\ndata-test-subj locators.","sha":"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab"}}]}] BACKPORT--> Co-authored-by: Karen Grigoryan <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kapral18
added a commit
to kapral18/kibana
that referenced
this pull request
Nov 18, 2024
…ests timing out on ci (elastic#196591) addresses elastic#196216 Removing accessibility selectors to ensure 10x speed of tests with data-test-subj locators. (cherry picked from commit b5a705e)
kapral18
added a commit
that referenced
this pull request
Nov 18, 2024
…ntial tests timing out on ci (#196591) (#200549) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591)](#196591) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T18:59:41Z","message":"[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591)\n\naddresses #196216\r\n\r\nRemoving accessibility selectors to ensure 10x speed of tests with\r\ndata-test-subj locators.","sha":"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:prev-minor","v8.17.0"],"number":196591,"url":"https://github.com/elastic/kibana/pull/196591","mergeCommit":{"message":"[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591)\n\naddresses #196216\r\n\r\nRemoving accessibility selectors to ensure 10x speed of tests with\r\ndata-test-subj locators.","sha":"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196591","number":196591,"mergeCommit":{"message":"[Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591)\n\naddresses #196216\r\n\r\nRemoving accessibility selectors to ensure 10x speed of tests with\r\ndata-test-subj locators.","sha":"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198717","number":198717,"state":"MERGED","mergeCommit":{"sha":"273a1eef0fb2f3c717f9fff8be2097892b8b8b90","message":"[8.x] [Security Solution][Data Quality Dashboard] fix tests and potential tests timing out on ci (#196591) (#198717)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Solution][Data Quality Dashboard] fix tests and potential\ntests timing out on ci\n(#196591)](https://github.com/elastic/kibana/pull/196591)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Karen\nGrigoryan\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-01T18:59:41Z\",\"message\":\"[Security\nSolution][Data Quality Dashboard] fix tests and potential tests timing\nout on ci (#196591)\\n\\naddresses #196216\\r\\n\\r\\nRemoving accessibility\nselectors to ensure 10x speed of tests with\\r\\ndata-test-subj\nlocators.\",\"sha\":\"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Threat\nHunting\",\"Team:Threat\nHunting:Explore\",\"backport:prev-minor\"],\"title\":\"[Security\nSolution][Data Quality Dashboard] fix tests and potential tests timing\nout on\nci\",\"number\":196591,\"url\":\"https://github.com/elastic/kibana/pull/196591\",\"mergeCommit\":{\"message\":\"[Security\nSolution][Data Quality Dashboard] fix tests and potential tests timing\nout on ci (#196591)\\n\\naddresses #196216\\r\\n\\r\\nRemoving accessibility\nselectors to ensure 10x speed of tests with\\r\\ndata-test-subj\nlocators.\",\"sha\":\"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196591\",\"number\":196591,\"mergeCommit\":{\"message\":\"[Security\nSolution][Data Quality Dashboard] fix tests and potential tests timing\nout on ci (#196591)\\n\\naddresses #196216\\r\\n\\r\\nRemoving accessibility\nselectors to ensure 10x speed of tests with\\r\\ndata-test-subj\nlocators.\",\"sha\":\"b5a705e54cd9c657064cc67f8cf1b72f4324d3ab\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Karen Grigoryan <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #196216
Removing accessibility selectors to ensure 10x speed of tests with data-test-subj locators.