-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security assistant] Fix AlertsRange
for Assistant
#196582
Merged
stephmilovic
merged 1 commit into
elastic:main
from
stephmilovic:fix_count_alerts_range
Oct 16, 2024
Merged
[Security assistant] Fix AlertsRange
for Assistant
#196582
stephmilovic
merged 1 commit into
elastic:main
from
stephmilovic:fix_count_alerts_range
Oct 16, 2024
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Team:Security Generative AI
Security Generative AI
v8.16.0
labels
Oct 16, 2024
Pinging @elastic/security-solution (Team: SecuritySolution) |
andrew-goldstein
approved these changes
Oct 16, 2024
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
(cherry picked from commit 6438520)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
…196582) (#196590) # Backport This will backport the following commits from `main` to `8.x`: - [[Security assistant] Fix `AlertsRange` for Assistant (#196582)](#196582) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T18:31:32Z","message":"[Security assistant] Fix `AlertsRange` for Assistant (#196582)","sha":"6438520c6522263bd38bf68606cf36fce4ce9697","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI","v8.16.0"],"title":"[Security assistant] Fix `AlertsRange` for Assistant","number":196582,"url":"https://github.com/elastic/kibana/pull/196582","mergeCommit":{"message":"[Security assistant] Fix `AlertsRange` for Assistant (#196582)","sha":"6438520c6522263bd38bf68606cf36fce4ce9697"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196582","number":196582,"mergeCommit":{"message":"[Security assistant] Fix `AlertsRange` for Assistant (#196582)","sha":"6438520c6522263bd38bf68606cf36fce4ce9697"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
release_note:skip
Skip the PR/issue when compiling release notes
Team:Security Generative AI
Security Generative AI
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.16.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I did a bad job on a merge conflict last night, bringing back the updates to the
AlertsRange
min/max/interval.