[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints #196580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samiul-TheSoccerFan
added
backport
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
TattdCodeMonkey
approved these changes
Oct 17, 2024
| @@ -14,9 +14,13 @@ import { ConfirmDeleteEndpointModal } from './confirm_delete_endpoint'; | |||
|
|
|||
| interface DeleteActionProps { | |||
| selectedEndpoint: InferenceEndpointUI; | |||
| preconfiguredEndpoint: boolean; | |||
There was a problem hiding this comment.
I think we should just name this disabled or we can just do the PRECONFIGURED_ENDPOINTS.includes(selectedEndpoint.endpoint) in this component instead of having this as a prop.
There was a problem hiding this comment.
I think this is better. I will update as suggested.
|
@Samiul-TheSoccerFan we should also include a 'preconfigured' badge next to these. See the attached design issue. Let me know if this is something that can be included in this PR or if it needs to be scoped elsewhere. |
|
@elasticmachine merge upstream |
Samiul-TheSoccerFan
force-pushed
the
handle-default-endpoint-from-inference-ui
branch
from
dd675cc to
22d0fbb
Compare
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.16 |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2024
…onfigured endpoints (elastic#196580) ## Summary Disables the delete action when the endpoints are preconfigured.  ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [X] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit dc219f9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
davidkyle
reviewed
Oct 23, 2024
| @@ -34,3 +34,8 @@ export const DEFAULT_INFERENCE_ENDPOINTS_TABLE_STATE: AllInferenceEndpointsTable | |||
| }; | |||
|
|
|||
| export const PIPELINE_URL = 'ingest/ingest_pipelines'; | |||
|
|
|||
| export const PRECONFIGURED_ENDPOINTS = { | |||
| ELSER: '.elser-2', | |||
There was a problem hiding this comment.
These endpoints are renamed in elastic/elasticsearch#115395
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
…ng preconfigured endpoints (#196580) (#197378) # Backport This will backport the following commits from `main` to `8.16`: - [[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580)](#196580) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T08:15:35Z","message":"[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580)\n\n## Summary\r\n\r\nDisables the delete action when the endpoints are preconfigured.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version"],"title":"[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints","number":196580,"url":"https://github.com/elastic/kibana/pull/196580","mergeCommit":{"message":"[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580)\n\n## Summary\r\n\r\nDisables the delete action when the endpoints are preconfigured.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196580","number":196580,"mergeCommit":{"message":"[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580)\n\n## Summary\r\n\r\nDisables the delete action when the endpoints are preconfigured.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Samiul Monir <[email protected]>
Samiul-TheSoccerFan
added a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Oct 24, 2024
…onfigured endpoints (elastic#196580) ## Summary Disables the delete action when the endpoints are preconfigured.  ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [X] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit dc219f9) # Conflicts: # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/constants.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Samiul-TheSoccerFan
added a commit
that referenced
this pull request
Oct 24, 2024
…g preconfigured endpoints (#196580) (#197720) # Backport This will backport the following commits from `main` to `8.x`: - [[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580)](#196580) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T08:15:35Z","message":"[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580)\n\n## Summary\r\n\r\nDisables the delete action when the endpoints are preconfigured.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0"],"number":196580,"url":"https://github.com/elastic/kibana/pull/196580","mergeCommit":{"message":"[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580)\n\n## Summary\r\n\r\nDisables the delete action when the endpoints are preconfigured.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196580","number":196580,"mergeCommit":{"message":"[Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580)\n\n## Summary\r\n\r\nDisables the delete action when the endpoints are preconfigured.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197378","number":197378,"state":"MERGED","mergeCommit":{"sha":"da9808cfc6aed9b2d801316a7e9ca6fcef6474aa","message":"[8.16] [Search: Inference Management UI] Adding restriction on deleting preconfigured endpoints (#196580) (#197378)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[Search: Inference Management UI] Adding restriction on deleting\npreconfigured endpoints\n(#196580)](https://github.com/elastic/kibana/pull/196580)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Samiul\nMonir\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-23T08:15:35Z\",\"message\":\"[Search:\nInference Management UI] Adding restriction on deleting preconfigured\nendpoints (#196580)\\n\\n## Summary\\r\\n\\r\\nDisables the delete action when\nthe endpoints are preconfigured.\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\nDelete any items that are not applicable to this\nPR.\\r\\n\\r\\n- [X] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common scenarios\\r\\n- [X] Any UI\ntouched in this PR does not create any new axe failures\\r\\n(run axe in\nbrowser:\\r\\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\\r\\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\\r\\n-\n[X] This renders correctly on smaller devices using a\nresponsive\\r\\nlayout. (You can test this [in\nyour\\r\\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\\r\\n-\n[X] This was checked for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\",\"sha\":\"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Search\",\"v8.16.0\",\"backport:version\"],\"title\":\"[Search:\nInference Management UI] Adding restriction on deleting preconfigured\nendpoints\",\"number\":196580,\"url\":\"https://github.com/elastic/kibana/pull/196580\",\"mergeCommit\":{\"message\":\"[Search:\nInference Management UI] Adding restriction on deleting preconfigured\nendpoints (#196580)\\n\\n## Summary\\r\\n\\r\\nDisables the delete action when\nthe endpoints are preconfigured.\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\nDelete any items that are not applicable to this\nPR.\\r\\n\\r\\n- [X] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common scenarios\\r\\n- [X] Any UI\ntouched in this PR does not create any new axe failures\\r\\n(run axe in\nbrowser:\\r\\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\\r\\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\\r\\n-\n[X] This renders correctly on smaller devices using a\nresponsive\\r\\nlayout. (You can test this [in\nyour\\r\\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\\r\\n-\n[X] This was checked for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\",\"sha\":\"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196580\",\"number\":196580,\"mergeCommit\":{\"message\":\"[Search:\nInference Management UI] Adding restriction on deleting preconfigured\nendpoints (#196580)\\n\\n## Summary\\r\\n\\r\\nDisables the delete action when\nthe endpoints are preconfigured.\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\nDelete any items that are not applicable to this\nPR.\\r\\n\\r\\n- [X] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common scenarios\\r\\n- [X] Any UI\ntouched in this PR does not create any new axe failures\\r\\n(run axe in\nbrowser:\\r\\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\\r\\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\\r\\n-\n[X] This renders correctly on smaller devices using a\nresponsive\\r\\nlayout. (You can test this [in\nyour\\r\\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\\r\\n-\n[X] This was checked for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\",\"sha\":\"dc219f9b309fe1582ce96d2c9ac9d42d91ea56bc\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Samiul Monir <[email protected]>"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disables the delete action when the endpoints are preconfigured.
Checklist
Delete any items that are not applicable to this PR.