Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataUsage][Serverless] Data usage charts enhancements #196559

Merged
merged 17 commits into from
Oct 18, 2024
Merged

[DataUsage][Serverless] Data usage charts enhancements #196559

merged 17 commits into from
Oct 18, 2024
+160 −195

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Oct 16, 2024 •
edited by kibanamachine
Loading

Summary

follow up of:

Adds a lot of enhancements to the datastream dropdown including:

  • shows storage sizes on the data stream dropdown
  • preselects all data streams on the first page load
  • updates selected data streams to URL params
  • selects data streams based on URL load
  • doesn't allow deselecting all data streams
  • cancels older API requests

screen

Screenshot 2024-10-16 at 16 57 43

clip

metrics-ux-16-10

related PRs

Checklist

@ashokaditya ashokaditya requested review from a team as code owners October 16, 2024 14:54
@ashokaditya ashokaditya self-assigned this Oct 16, 2024
@ashokaditya ashokaditya added v9.0.0 v8.16.0 backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes labels Oct 16, 2024
@ashokaditya ashokaditya mentioned this pull request Oct 16, 2024
Open
@neptunian
Copy link
Contributor

neptunian commented Oct 17, 2024 •
edited
Loading

Whenever i select or unselect a data stream I get two requests to /metrics with the same payload. I'm also still getting the initial 400 error when i load the page due to sending the empty data streams array.

@ashokaditya ashokaditya force-pushed the feat/data-usage-charts-enhancements-192965-192966 branch from 6cc7453 to 2f56a29 Compare October 17, 2024 14:22
@ashokaditya
Copy link
Member Author

Whenever i select or unselect a data stream I get two requests to /metrics with the same payload. I'm also still getting the initial 400 error when i load the page due to sending the empty data streams array.

yeah, I fixed that as well.

@ashokaditya ashokaditya requested a review from neptunian October 17, 2024 14:23
@ashokaditya ashokaditya force-pushed the feat/data-usage-charts-enhancements-192965-192966 branch from b8b3160 to c7b16e7 Compare October 17, 2024 15:37
@neptunian
Copy link
Contributor

neptunian commented Oct 17, 2024 •
edited
Loading

Looks great! I do still get the issue where if I select a data stream (not deselect), i get two of the same metrics requests/responses. It doesn't do it if I'm only selecting a total of 1 data streams, though (from zero).

@ashokaditya
Copy link
Member Author

ashokaditya commented Oct 17, 2024 •
edited
Loading

Looks great! I do still get the issue where if I select a data stream (not deselect), i get two of the same metrics requests/responses. It doesn't do it if I'm only selecting a total of 1 data streams, though (from zero).

Oh right. I see that too. It's cause the list is being sorted and that is a new query key so it makes a new request. fixed in 6cd61ba

@neptunian
Copy link
Contributor

neptunian commented Oct 17, 2024 •
edited
Loading

We can do this in a followup - but I'm thinking there is no reason to make the /metrics request when removing a datastream from the filter dropdown. We aren't getting any new data unless we are adding a datastream or the time range has changed. Given we default by selecting all, if a user wants to remove several data streams, making requests for no reason and causing the charts to have to wait and re render would not be a great experience.

@ashokaditya
Copy link
Member Author

I think we should allow users to see less data for fewer indices/datastreams should they like. They might want to see fewer indices on the charts instead of being overwhelmed by looking at data for several at a time.

I agree. My question is why do we need to make a request to /metrics when they remove data streams? We are not getting any new data in that case? We need to update the UI state but we don't need to make a request. If we didn't have to make a request as they removed data streams the chart would update immediately instead of having to wait for the request. This is a performance optimization I'm getting at and it adds a little bit of complexity. I mainly mention it because this request can take some time due to the external call - so it may be worth it.

Ah, I see what you mean by improving performance. That makes sense if we can correctly assume that "there's no new data" meaning non of the metrics data changes after the intiial request.

I would expect that ingestion rate and storage rate is in fact constantly changing while (any arbitrary of time) users are looking at the charts.

@neptunian
Copy link
Contributor

I would expect that ingestion rate and storage rate is in fact constantly changing while (any arbitrary of time) users are looking at the charts.

That's true. I was thinking that so long as the time range didn't change, nothing would change, but since we default to a relative time range, it's probably an unlikely scenario and not worth pursuing.

@ashokaditya
Copy link
Member Author

I would expect that ingestion rate and storage rate is in fact constantly changing while (any arbitrary of time) users are looking at the charts.

That's true. I was thinking that so long as the time range didn't change, nothing would change, but since we default to a relative time range, it's probably an unlikely scenario and not worth pursuing.

Oh right. Thanks for clarifying. Yeah if the end date is not set to now then it makes sense to optimize requests. I can try and test it out when I work on the new PR.

@ashokaditya ashokaditya enabled auto-merge (squash) October 18, 2024 13:01
@ashokaditya ashokaditya merged commit 13e19cb into elastic:main Oct 18, 2024
33 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16

https://github.com/elastic/kibana/actions/runs/11404361214

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #19 / useGetCaseUserActionsStats returns proper state on getCaseUserActionsStats

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataUsage 237.8KB 237.6KB -230.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataUsage 4.6KB 4.5KB -54.0B

History

cc @ashokaditya

@ashokaditya ashokaditya deleted the feat/data-usage-charts-enhancements-192965-192966 branch October 18, 2024 13:13
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
@ashokaditya
[DataUsage][Serverless] Data usage charts enhancements (elastic#196559)
da174cc 
## Summary

follow up of:
- elastic/pull/195556

Adds a lot of enhancements to the datastream dropdown including:

- [x] shows storage sizes on the data stream dropdown
- [x] preselects all data streams on the first page load
- [x] updates selected data streams to URL params
- [x] selects data streams based on URL load
- [x] doesn't allow deselecting all data streams
- [x] cancels older API requests

### screen
![Screenshot 2024-10-16 at 16 57
43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)

### clip

![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)

related PRs
- elastic/pull/193966

### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 13e19cb)
@kibanamachine kibanamachine mentioned this pull request Oct 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 18, 2024
@kibanamachine @ashokaditya
[8.16] [DataUsage][Serverless] Data usage charts enhancements (#196559)…
79e7c86 
… (#196876)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[DataUsage][Serverless] Data usage charts enhancements
(#196559)](#196559)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T13:10:30Z","message":"[DataUsage][Serverless]
Data usage charts enhancements (#196559)\n\n## Summary\r\n\r\nfollow up
of:\r\n- /pull/195556\r\n\r\nAdds a lot of enhancements to
the datastream dropdown including:\r\n\r\n- [x] shows storage sizes on
the data stream dropdown\r\n- [x] preselects all data streams on the
first page load\r\n- [x] updates selected data streams to URL
params\r\n- [x] selects data streams based on URL load\r\n- [x] doesn't
allow deselecting all data streams\r\n- [x] cancels older API
requests\r\n\r\n### screen\r\n![Screenshot 2024-10-16 at 16
57\r\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\r\n\r\n###
clip\r\n\r\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\r\n\r\nrelated
PRs\r\n- /pull/193966 \r\n \r\n### Checklist\r\n- [x] Any
text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR does
not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"13e19cb645e3e3b037ea40809dfbfdaf93529169","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[DataUsage][Serverless]
Data usage charts
enhancements","number":196559,"url":"https://github.com/elastic/kibana/pull/196559","mergeCommit":{"message":"[DataUsage][Serverless]
Data usage charts enhancements (#196559)\n\n## Summary\r\n\r\nfollow up
of:\r\n- /pull/195556\r\n\r\nAdds a lot of enhancements to
the datastream dropdown including:\r\n\r\n- [x] shows storage sizes on
the data stream dropdown\r\n- [x] preselects all data streams on the
first page load\r\n- [x] updates selected data streams to URL
params\r\n- [x] selects data streams based on URL load\r\n- [x] doesn't
allow deselecting all data streams\r\n- [x] cancels older API
requests\r\n\r\n### screen\r\n![Screenshot 2024-10-16 at 16
57\r\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\r\n\r\n###
clip\r\n\r\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\r\n\r\nrelated
PRs\r\n- /pull/193966 \r\n \r\n### Checklist\r\n- [x] Any
text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR does
not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"13e19cb645e3e3b037ea40809dfbfdaf93529169"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196559","number":196559,"mergeCommit":{"message":"[DataUsage][Serverless]
Data usage charts enhancements (#196559)\n\n## Summary\r\n\r\nfollow up
of:\r\n- /pull/195556\r\n\r\nAdds a lot of enhancements to
the datastream dropdown including:\r\n\r\n- [x] shows storage sizes on
the data stream dropdown\r\n- [x] preselects all data streams on the
first page load\r\n- [x] updates selected data streams to URL
params\r\n- [x] selects data streams based on URL load\r\n- [x] doesn't
allow deselecting all data streams\r\n- [x] cancels older API
requests\r\n\r\n### screen\r\n![Screenshot 2024-10-16 at 16
57\r\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\r\n\r\n###
clip\r\n\r\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\r\n\r\nrelated
PRs\r\n- /pull/193966 \r\n \r\n### Checklist\r\n- [x] Any
text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR does
not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"13e19cb645e3e3b037ea40809dfbfdaf93529169"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ash <[email protected]>
@jbudz
Copy link
Member

jbudz commented Oct 18, 2024

@ashokaditya there's a version gap with this backport. Can you check if this should also be backported to 8.x/8.17?

@ashokaditya
Copy link
Member Author

@ashokaditya there's a version gap with this backport. Can you check if this should also be backported to 8.x/8.17?

yeah it should be backported to 8.x/8.17

@ashokaditya ashokaditya mentioned this pull request Oct 21, 2024
Merged
@ashokaditya
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Oct 21, 2024
@ashokaditya
[DataUsage][Serverless] Data usage charts enhancements (elastic#196559)
4aa8e77 
## Summary

follow up of:
- elastic/pull/195556

Adds a lot of enhancements to the datastream dropdown including:

- [x] shows storage sizes on the data stream dropdown
- [x] preselects all data streams on the first page load
- [x] updates selected data streams to URL params
- [x] selects data streams based on URL load
- [x] doesn't allow deselecting all data streams
- [x] cancels older API requests

### screen
![Screenshot 2024-10-16 at 16 57
43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)

### clip

![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)

related PRs
- elastic/pull/193966

### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 13e19cb)
@ashokaditya ashokaditya mentioned this pull request Oct 21, 2024
Merged
2 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 22, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

ashokaditya added a commit that referenced this pull request Oct 23, 2024
@ashokaditya
[8.x] [DataUsage][Serverless] Data usage charts enhancements (#196559) (
0bd80e5 
#196996)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[DataUsage][Serverless] Data usage charts enhancements
(#196559)](#196559)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T13:10:30Z","message":"[DataUsage][Serverless]
Data usage charts enhancements (#196559)\n\n## Summary\r\n\r\nfollow up
of:\r\n- /pull/195556\r\n\r\nAdds a lot of enhancements to
the datastream dropdown including:\r\n\r\n- [x] shows storage sizes on
the data stream dropdown\r\n- [x] preselects all data streams on the
first page load\r\n- [x] updates selected data streams to URL
params\r\n- [x] selects data streams based on URL load\r\n- [x] doesn't
allow deselecting all data streams\r\n- [x] cancels older API
requests\r\n\r\n### screen\r\n![Screenshot 2024-10-16 at 16
57\r\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\r\n\r\n###
clip\r\n\r\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\r\n\r\nrelated
PRs\r\n- /pull/193966 \r\n \r\n### Checklist\r\n- [x] Any
text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR does
not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"13e19cb645e3e3b037ea40809dfbfdaf93529169","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0"],"number":196559,"url":"https://github.com/elastic/kibana/pull/196559","mergeCommit":{"message":"[DataUsage][Serverless]
Data usage charts enhancements (#196559)\n\n## Summary\r\n\r\nfollow up
of:\r\n- /pull/195556\r\n\r\nAdds a lot of enhancements to
the datastream dropdown including:\r\n\r\n- [x] shows storage sizes on
the data stream dropdown\r\n- [x] preselects all data streams on the
first page load\r\n- [x] updates selected data streams to URL
params\r\n- [x] selects data streams based on URL load\r\n- [x] doesn't
allow deselecting all data streams\r\n- [x] cancels older API
requests\r\n\r\n### screen\r\n![Screenshot 2024-10-16 at 16
57\r\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\r\n\r\n###
clip\r\n\r\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\r\n\r\nrelated
PRs\r\n- /pull/193966 \r\n \r\n### Checklist\r\n- [x] Any
text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR does
not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"13e19cb645e3e3b037ea40809dfbfdaf93529169"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196559","number":196559,"mergeCommit":{"message":"[DataUsage][Serverless]
Data usage charts enhancements (#196559)\n\n## Summary\r\n\r\nfollow up
of:\r\n- /pull/195556\r\n\r\nAdds a lot of enhancements to
the datastream dropdown including:\r\n\r\n- [x] shows storage sizes on
the data stream dropdown\r\n- [x] preselects all data streams on the
first page load\r\n- [x] updates selected data streams to URL
params\r\n- [x] selects data streams based on URL load\r\n- [x] doesn't
allow deselecting all data streams\r\n- [x] cancels older API
requests\r\n\r\n### screen\r\n![Screenshot 2024-10-16 at 16
57\r\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\r\n\r\n###
clip\r\n\r\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\r\n\r\nrelated
PRs\r\n- /pull/193966 \r\n \r\n### Checklist\r\n- [x] Any
text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR does
not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"13e19cb645e3e3b037ea40809dfbfdaf93529169"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196876","number":196876,"state":"MERGED","mergeCommit":{"sha":"79e7c86a094093c8fb40d9152ab84d6f773a3eea","message":"[8.16]
[DataUsage][Serverless] Data usage charts enhancements (#196559)
(#196876)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.16`:\n- [[DataUsage][Serverless] Data usage charts
enhancements\n(#196559)](https://github.com/elastic/kibana/pull/196559)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"Ash\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-18T13:10:30Z\",\"message\":\"[DataUsage][Serverless]\nData
usage charts enhancements (#196559)\\n\\n## Summary\\r\\n\\r\\nfollow
up\nof:\\r\\n- /pull/195556\\r\\n\\r\\nAdds a lot of
enhancements to\nthe datastream dropdown including:\\r\\n\\r\\n- [x]
shows storage sizes on\nthe data stream dropdown\\r\\n- [x] preselects
all data streams on the\nfirst page load\\r\\n- [x] updates selected
data streams to URL\nparams\\r\\n- [x] selects data streams based on URL
load\\r\\n- [x] doesn't\nallow deselecting all data streams\\r\\n- [x]
cancels older API\nrequests\\r\\n\\r\\n### screen\\r\\n![Screenshot
2024-10-16 at
16\n57\\r\\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\\r\\n\\r\\n###\nclip\\r\\n\\r\\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\\r\\n\\r\\nrelated\nPRs\\r\\n-
/pull/193966 \\r\\n \\r\\n### Checklist\\r\\n- [x]
Any\ntext added follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[
] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [ ]
[Flaky\nTest\\r\\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)\nwas\\r\\nused
on any tests changed\\r\\n- [x] Any UI touched in this PR does\nnot
create any new axe failures\\r\\n(run axe
in\nbrowser:\\r\\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\\r\\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\\r\\n-\n[x]
This renders correctly on smaller devices using
a\nresponsive\\r\\nlayout. (You can test this
[in\nyour\\r\\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\\r\\n-\n[x]
This was checked
for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"13e19cb645e3e3b037ea40809dfbfdaf93529169\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"v8.16.0\",\"backport:version\"],\"title\":\"[DataUsage][Serverless]\nData
usage
charts\nenhancements\",\"number\":196559,\"url\":\"https://github.com/elastic/kibana/pull/196559\",\"mergeCommit\":{\"message\":\"[DataUsage][Serverless]\nData
usage charts enhancements (#196559)\\n\\n## Summary\\r\\n\\r\\nfollow
up\nof:\\r\\n- /pull/195556\\r\\n\\r\\nAdds a lot of
enhancements to\nthe datastream dropdown including:\\r\\n\\r\\n- [x]
shows storage sizes on\nthe data stream dropdown\\r\\n- [x] preselects
all data streams on the\nfirst page load\\r\\n- [x] updates selected
data streams to URL\nparams\\r\\n- [x] selects data streams based on URL
load\\r\\n- [x] doesn't\nallow deselecting all data streams\\r\\n- [x]
cancels older API\nrequests\\r\\n\\r\\n### screen\\r\\n![Screenshot
2024-10-16 at
16\n57\\r\\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\\r\\n\\r\\n###\nclip\\r\\n\\r\\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\\r\\n\\r\\nrelated\nPRs\\r\\n-
/pull/193966 \\r\\n \\r\\n### Checklist\\r\\n- [x]
Any\ntext added follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[
] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [ ]
[Flaky\nTest\\r\\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)\nwas\\r\\nused
on any tests changed\\r\\n- [x] Any UI touched in this PR does\nnot
create any new axe failures\\r\\n(run axe
in\nbrowser:\\r\\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\\r\\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\\r\\n-\n[x]
This renders correctly on smaller devices using
a\nresponsive\\r\\nlayout. (You can test this
[in\nyour\\r\\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\\r\\n-\n[x]
This was checked
for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"13e19cb645e3e3b037ea40809dfbfdaf93529169\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196559\",\"number\":196559,\"mergeCommit\":{\"message\":\"[DataUsage][Serverless]\nData
usage charts enhancements (#196559)\\n\\n## Summary\\r\\n\\r\\nfollow
up\nof:\\r\\n- /pull/195556\\r\\n\\r\\nAdds a lot of
enhancements to\nthe datastream dropdown including:\\r\\n\\r\\n- [x]
shows storage sizes on\nthe data stream dropdown\\r\\n- [x] preselects
all data streams on the\nfirst page load\\r\\n- [x] updates selected
data streams to URL\nparams\\r\\n- [x] selects data streams based on URL
load\\r\\n- [x] doesn't\nallow deselecting all data streams\\r\\n- [x]
cancels older API\nrequests\\r\\n\\r\\n### screen\\r\\n![Screenshot
2024-10-16 at
16\n57\\r\\n43](https://github.com/user-attachments/assets/38db2d93-f531-4269-88ea-51b4926b6a72)\\r\\n\\r\\n###\nclip\\r\\n\\r\\n![metrics-ux-16-10](https://github.com/user-attachments/assets/7913d1b6-31df-48e6-a3a9-f4dad0dc1b1e)\\r\\n\\r\\nrelated\nPRs\\r\\n-
/pull/193966 \\r\\n \\r\\n### Checklist\\r\\n- [x]
Any\ntext added follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[
] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most common scenarios\\r\\n- [ ]
[Flaky\nTest\\r\\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)\nwas\\r\\nused
on any tests changed\\r\\n- [x] Any UI touched in this PR does\nnot
create any new axe failures\\r\\n(run axe
in\nbrowser:\\r\\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\\r\\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\\r\\n-\n[x]
This renders correctly on smaller devices using
a\nresponsive\\r\\nlayout. (You can test this
[in\nyour\\r\\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\\r\\n-\n[x]
This was checked
for\n[cross-browser\\r\\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"13e19cb645e3e3b037ea40809dfbfdaf93529169\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Ash
<[email protected]>"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 23, 2024
@ashokaditya ashokaditya mentioned this pull request Oct 28, 2024
Merged
2 tasks
ashokaditya added a commit that referenced this pull request Nov 7, 2024
@ashokaditya @kibanamachine
[DataUsage][Serverless] Add missing tests (#198007)
207894e 
## Summary

Adds missing UX/API tests for changes added in 
- #193966
- #197056
- #195556
- #196559


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 7, 2024
@ashokaditya
[DataUsage][Serverless] Add missing tests (elastic#198007)
a3eb8be 
## Summary

Adds missing UX/API tests for changes added in
- elastic#193966
- elastic#197056
- elastic#195556
- elastic#196559

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 207894e)
mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 8, 2024
@ashokaditya @kibanamachine @mbondyra
[DataUsage][Serverless] Add missing tests (elastic#198007)
b56d95c 
## Summary

Adds missing UX/API tests for changes added in 
- elastic#193966
- elastic#197056
- elastic#195556
- elastic#196559


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 8, 2024
@ashokaditya @kibanamachine @CAWilson94
[DataUsage][Serverless] Add missing tests (elastic#198007)
7f0131a 
## Summary

Adds missing UX/API tests for changes added in 
- elastic#193966
- elastic#197056
- elastic#195556
- elastic#196559


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian approved these changes

@YulNaumenko YulNaumenko Awaiting requested review from YulNaumenko

Assignees

@ashokaditya ashokaditya

Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashokaditya @neptunian @kibanamachine @elasticmachine @jbudz