Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Fix report flyout content overflowing #196552

Conversation

kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Oct 16, 2024

Summary

This PR fixes text overflowing in the report flyout.

Fixes: #153699

Visuals

Previous New
image image

@kowalczyk-krzysztof kowalczyk-krzysztof added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export labels Oct 16, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner October 16, 2024 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Oct 16, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #107 / ObservabilityApp Observability Rule Details page Alert summary widget component handles clicking on total alerts correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 61.0KB 61.2KB +137.0B

cc @kowalczyk-krzysztof

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit a2d8556 into elastic:main Oct 17, 2024
32 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11380315293

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
## Summary

This PR fixes text overflowing in the report flyout.

Fixes: elastic#153699

## Visuals
| Previous | New |
|-----------------|-----------------|

|![image](https://github.com/user-attachments/assets/ae9c5ead-0689-4a16-8f3f-88342e4fbc94)
|
![image](https://github.com/user-attachments/assets/e7193a8e-8b35-49fa-a98f-4b3cac3a4791)
|

(cherry picked from commit a2d8556)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 17, 2024
…96634)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Reporting] Fix report flyout content overflowing
(#196552)](#196552)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T07:26:27Z","message":"[Reporting]
Fix report flyout content overflowing (#196552)\n\n##
Summary\r\n\r\nThis PR fixes text overflowing in the report
flyout.\r\n\r\nFixes: #153699\r\n\r\n## Visuals\r\n| Previous | New
|\r\n|-----------------|-----------------|\r\n\r\n|![image](https://github.com/user-attachments/assets/ae9c5ead-0689-4a16-8f3f-88342e4fbc94)\r\n|\r\n![image](https://github.com/user-attachments/assets/e7193a8e-8b35-49fa-a98f-4b3cac3a4791)\r\n|","sha":"a2d855649cc4794a037133778be9ad885be53bdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Feature:Reporting:Screenshot"],"title":"[Reporting]
Fix report flyout content
overflowing","number":196552,"url":"https://github.com/elastic/kibana/pull/196552","mergeCommit":{"message":"[Reporting]
Fix report flyout content overflowing (#196552)\n\n##
Summary\r\n\r\nThis PR fixes text overflowing in the report
flyout.\r\n\r\nFixes: #153699\r\n\r\n## Visuals\r\n| Previous | New
|\r\n|-----------------|-----------------|\r\n\r\n|![image](https://github.com/user-attachments/assets/ae9c5ead-0689-4a16-8f3f-88342e4fbc94)\r\n|\r\n![image](https://github.com/user-attachments/assets/e7193a8e-8b35-49fa-a98f-4b3cac3a4791)\r\n|","sha":"a2d855649cc4794a037133778be9ad885be53bdb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196552","number":196552,"mergeCommit":{"message":"[Reporting]
Fix report flyout content overflowing (#196552)\n\n##
Summary\r\n\r\nThis PR fixes text overflowing in the report
flyout.\r\n\r\nFixes: #153699\r\n\r\n## Visuals\r\n| Previous | New
|\r\n|-----------------|-----------------|\r\n\r\n|![image](https://github.com/user-attachments/assets/ae9c5ead-0689-4a16-8f3f-88342e4fbc94)\r\n|\r\n![image](https://github.com/user-attachments/assets/e7193a8e-8b35-49fa-a98f-4b3cac3a4791)\r\n|","sha":"a2d855649cc4794a037133778be9ad885be53bdb"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase timeout for xpack.screenshotting.capture.timeouts.renderComplete warning panel has text overflowing
4 participants