-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Fix report flyout content overflowing #196552
Merged
kowalczyk-krzysztof
merged 2 commits into
elastic:main
from
kowalczyk-krzysztof:fix/report_flyout_wordwrap
Oct 17, 2024
Merged
[Reporting] Fix report flyout content overflowing #196552
kowalczyk-krzysztof
merged 2 commits into
elastic:main
from
kowalczyk-krzysztof:fix/report_flyout_wordwrap
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowalczyk-krzysztof
added
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Feature:Reporting:Screenshot
Reporting issues pertaining to PNG/PDF file export
labels
Oct 16, 2024
Pinging @elastic/appex-sharedux (Team:SharedUX) |
tsullivan
approved these changes
Oct 16, 2024
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
## Summary This PR fixes text overflowing in the report flyout. Fixes: elastic#153699 ## Visuals | Previous | New | |-----------------|-----------------| |![image](https://github.com/user-attachments/assets/ae9c5ead-0689-4a16-8f3f-88342e4fbc94) | ![image](https://github.com/user-attachments/assets/e7193a8e-8b35-49fa-a98f-4b3cac3a4791) | (cherry picked from commit a2d8556)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
…96634) # Backport This will backport the following commits from `main` to `8.x`: - [[Reporting] Fix report flyout content overflowing (#196552)](#196552) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T07:26:27Z","message":"[Reporting] Fix report flyout content overflowing (#196552)\n\n## Summary\r\n\r\nThis PR fixes text overflowing in the report flyout.\r\n\r\nFixes: #153699\r\n\r\n## Visuals\r\n| Previous | New |\r\n|-----------------|-----------------|\r\n\r\n|![image](https://github.com/user-attachments/assets/ae9c5ead-0689-4a16-8f3f-88342e4fbc94)\r\n|\r\n![image](https://github.com/user-attachments/assets/e7193a8e-8b35-49fa-a98f-4b3cac3a4791)\r\n|","sha":"a2d855649cc4794a037133778be9ad885be53bdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Feature:Reporting:Screenshot"],"title":"[Reporting] Fix report flyout content overflowing","number":196552,"url":"https://github.com/elastic/kibana/pull/196552","mergeCommit":{"message":"[Reporting] Fix report flyout content overflowing (#196552)\n\n## Summary\r\n\r\nThis PR fixes text overflowing in the report flyout.\r\n\r\nFixes: #153699\r\n\r\n## Visuals\r\n| Previous | New |\r\n|-----------------|-----------------|\r\n\r\n|![image](https://github.com/user-attachments/assets/ae9c5ead-0689-4a16-8f3f-88342e4fbc94)\r\n|\r\n![image](https://github.com/user-attachments/assets/e7193a8e-8b35-49fa-a98f-4b3cac3a4791)\r\n|","sha":"a2d855649cc4794a037133778be9ad885be53bdb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196552","number":196552,"mergeCommit":{"message":"[Reporting] Fix report flyout content overflowing (#196552)\n\n## Summary\r\n\r\nThis PR fixes text overflowing in the report flyout.\r\n\r\nFixes: #153699\r\n\r\n## Visuals\r\n| Previous | New |\r\n|-----------------|-----------------|\r\n\r\n|![image](https://github.com/user-attachments/assets/ae9c5ead-0689-4a16-8f3f-88342e4fbc94)\r\n|\r\n![image](https://github.com/user-attachments/assets/e7193a8e-8b35-49fa-a98f-4b3cac3a4791)\r\n|","sha":"a2d855649cc4794a037133778be9ad885be53bdb"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
bug
Fixes for quality problems that affect the customer experience
Feature:Reporting:Screenshot
Reporting issues pertaining to PNG/PDF file export
release_note:skip
Skip the PR/issue when compiling release notes
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes text overflowing in the report flyout.
Fixes: #153699
Visuals