[Search] [Onboarding] Update Breadcrumbs and title for search detail page #196538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
added
backport:prev-minor
joemcelroy
commented
Oct 16, 2024
| useEffect(() => { | ||
| chrome.docTitle.change(indexName); | ||
|
|
||
| if (serverless) { |
There was a problem hiding this comment.
We decided for now to do this route until the search_navigation plugin comes in where it will handle for the differences between stack and serverless.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7150[✅] x-pack/test_serverless/api_integration/test_suites/search/config.feature_flags.ts: 25/25 tests passed. |
sphilipse
reviewed
Oct 16, 2024
x-pack/plugins/search_indices/public/components/indices/details_page.tsx
Show resolved
Hide resolved
jloleysens
approved these changes
Oct 17, 2024
sphilipse
approved these changes
Oct 17, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
…page (elastic#196538) ## Summary Update breadcrumbs and title when on search details page. https://github.com/user-attachments/assets/1f6177ac-e273-492a-91da-1d7fadb30bf1 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit e1f227d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
…etail page (#196538) (#196701) # Backport This will backport the following commits from `main` to `8.x`: - [[Search] [Onboarding] Update Breadcrumbs and title for search detail page (#196538)](#196538) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe McElroy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T13:47:04Z","message":"[Search] [Onboarding] Update Breadcrumbs and title for search detail page (#196538)\n\n## Summary\r\n\r\nUpdate breadcrumbs and title when on search details page.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1f6177ac-e273-492a-91da-1d7fadb30bf1\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e1f227d4644a11d46fac9c3592278081b577d0ae","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[Search] [Onboarding] Update Breadcrumbs and title for search detail page","number":196538,"url":"https://github.com/elastic/kibana/pull/196538","mergeCommit":{"message":"[Search] [Onboarding] Update Breadcrumbs and title for search detail page (#196538)\n\n## Summary\r\n\r\nUpdate breadcrumbs and title when on search details page.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1f6177ac-e273-492a-91da-1d7fadb30bf1\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e1f227d4644a11d46fac9c3592278081b577d0ae"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196538","number":196538,"mergeCommit":{"message":"[Search] [Onboarding] Update Breadcrumbs and title for search detail page (#196538)\n\n## Summary\r\n\r\nUpdate breadcrumbs and title when on search details page.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1f6177ac-e273-492a-91da-1d7fadb30bf1\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e1f227d4644a11d46fac9c3592278081b577d0ae"}}]}] BACKPORT--> Co-authored-by: Joe McElroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update breadcrumbs and title when on search details page.
Screen.Recording.2024-10-16.at.12.48.33.mov
Checklist
Delete any items that are not applicable to this PR.