[Security Solution][Serverless Quality Gate] Restoring overrides functionality #196536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkirchan
added
release_note:skip
dkirchan
requested review from
MadameSheema,
patrykkopycinski,
maximpn and
banderror
as code owners
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
dkirchan
added
v9.0.0
backport:prev-minor
MadameSheema
approved these changes
Oct 16, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @dkirchan |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
…tionality (elastic#196536) ## Summary Due to a bug introduced in a previous PR, the `override` value was never using the `process.env.KIBANA_MKI_IMAGE_COMMIT` environment variable. The reason is that in the command line arguments argparse, commit value had the default of `''` so the commit was never null or undefined. ``` .option('commit', { alias: 'c', type: 'string', default: '', }) ``` Restored the check to see if the string is also empty. (cherry picked from commit cbe5d9a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
…s functionality (#196536) (#196608) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Serverless Quality Gate] Restoring overrides functionality (#196536)](#196536) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"dkirchan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T20:47:27Z","message":"[Security Solution][Serverless Quality Gate] Restoring overrides functionality (#196536)\n\n## Summary\r\n\r\nDue to a bug introduced in a previous PR, the `override` value was never\r\nusing the `process.env.KIBANA_MKI_IMAGE_COMMIT` environment variable.\r\n\r\nThe reason is that in the command line arguments argparse, commit value\r\nhad the default of `''` so the commit was never null or undefined.\r\n\r\n```\r\n .option('commit', {\r\n alias: 'c',\r\n type: 'string',\r\n default: '',\r\n })\r\n```\r\n\r\nRestored the check to see if the string is also empty.","sha":"cbe5d9a8fb57bf808d69c3ca35c0fefca7ef54e2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","v8.16.0"],"title":"[Security Solution][Serverless Quality Gate] Restoring overrides functionality","number":196536,"url":"https://github.com/elastic/kibana/pull/196536","mergeCommit":{"message":"[Security Solution][Serverless Quality Gate] Restoring overrides functionality (#196536)\n\n## Summary\r\n\r\nDue to a bug introduced in a previous PR, the `override` value was never\r\nusing the `process.env.KIBANA_MKI_IMAGE_COMMIT` environment variable.\r\n\r\nThe reason is that in the command line arguments argparse, commit value\r\nhad the default of `''` so the commit was never null or undefined.\r\n\r\n```\r\n .option('commit', {\r\n alias: 'c',\r\n type: 'string',\r\n default: '',\r\n })\r\n```\r\n\r\nRestored the check to see if the string is also empty.","sha":"cbe5d9a8fb57bf808d69c3ca35c0fefca7ef54e2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196536","number":196536,"mergeCommit":{"message":"[Security Solution][Serverless Quality Gate] Restoring overrides functionality (#196536)\n\n## Summary\r\n\r\nDue to a bug introduced in a previous PR, the `override` value was never\r\nusing the `process.env.KIBANA_MKI_IMAGE_COMMIT` environment variable.\r\n\r\nThe reason is that in the command line arguments argparse, commit value\r\nhad the default of `''` so the commit was never null or undefined.\r\n\r\n```\r\n .option('commit', {\r\n alias: 'c',\r\n type: 'string',\r\n default: '',\r\n })\r\n```\r\n\r\nRestored the check to see if the string is also empty.","sha":"cbe5d9a8fb57bf808d69c3ca35c0fefca7ef54e2"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: dkirchan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to a bug introduced in a previous PR, the
overridevalue was never using theprocess.env.KIBANA_MKI_IMAGE_COMMITenvironment variable.The reason is that in the command line arguments argparse, commit value had the default of
''so the commit was never null or undefined.Restored the check to see if the string is also empty.