Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature flags example] Apply FF naming conventions #196535

Merged
merged 7 commits into from
Oct 17, 2024
Merged

[Feature flags example] Apply FF naming conventions #196535

merged 7 commits into from
Oct 17, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Oct 16, 2024

Summary

Just updating the name of the feature flags defined in the Feature Flags example plugin to comply with our naming conventions pluginName.featureFlagName in camelCase.

Also adding support to dotted feature flag names in the config overrides.

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 16, 2024
@afharo afharo requested a review from a team as a code owner October 16, 2024 11:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo self-assigned this Oct 16, 2024
@afharo afharo enabled auto-merge (squash) October 16, 2024 12:05
@afharo afharo merged commit f25b3be into elastic:main Oct 17, 2024
24 checks passed
@afharo afharo deleted the feature-flags-example/apply-ff-naming-conventions branch October 17, 2024 09:34
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 450.0KB 450.0KB +2.0B

History

cc @afharo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf approved these changes

Assignees

@afharo afharo

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afharo @elasticmachine @rudolf @kibanamachine