Make sort integration test resilient to network delays. #196516
Conversation
awahab07
added
release_note:skip
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
awahab07
added
the
bug
| await retry.try(async () => { | ||
| await PageObjects.observabilityLogsExplorer.clickSortButtonBy('desc'); |
There was a problem hiding this comment.
Wouldn't be better here just to await until the proper button is clicked?
There was a problem hiding this comment.
The await on button click works and reflects the correct UI state. The problem is we can't determine if the network call against the button click succeeds or fails. Doing this should re-issue the network call in retry if previous one fails or takes longer.
There was a problem hiding this comment.
From what I saw directly in the UI, the call made doesn't include the sort attribute, so calling it for the proper asc value would be enough. I don't get why we are calling asc and then desc, and viceversa.
There was a problem hiding this comment.
I don't get why we are calling asc and then desc, and viceversa
Without toggling the asc/desc, it doesn't re-issue the request:
does-not-send-request-only-one-button.mov
With the toggle it re-issues the request on each retry:
retry-on-test-failure.mov
the call made doesn't include the sort attribute
If you mean the sort attribute in API call, the sort asc/desc request does include the sort param.
There was a problem hiding this comment.
If you mean the sort attribute in API call, the sort asc/desc request does include the sort param.
I missed it somehow 😓
With the toggle it re-issues the request on each retry
I think that a weird behaviour, thanks for digging into it
…s-logs-explorer-sort
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7152[✅] x-pack/test_serverless/functional/test_suites/observability/config.ts: 100/100 tests passed. |
…s-logs-explorer-sort
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
Fixes elastic#182017 ## Summary The PR tries to address the flakiness from the test. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit cbf7982)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… (#197237) # Backport This will backport the following commits from `main` to `8.x`: - [Make sort integration test resilient to network delays. (#196516)](#196516) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T13:11:08Z","message":"Make sort integration test resilient to network delays. (#196516)\n\nFixes https://github.com/elastic/kibana/issues/182017\r\n\r\n## Summary\r\n\r\nThe PR tries to address the flakiness from the test.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"cbf7982887decc527455dd8f64477813e8ea2672","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"Make sort integration test resilient to network delays.","number":196516,"url":"https://github.com/elastic/kibana/pull/196516","mergeCommit":{"message":"Make sort integration test resilient to network delays. (#196516)\n\nFixes https://github.com/elastic/kibana/issues/182017\r\n\r\n## Summary\r\n\r\nThe PR tries to address the flakiness from the test.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"cbf7982887decc527455dd8f64477813e8ea2672"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196516","number":196516,"mergeCommit":{"message":"Make sort integration test resilient to network delays. (#196516)\n\nFixes https://github.com/elastic/kibana/issues/182017\r\n\r\n## Summary\r\n\r\nThe PR tries to address the flakiness from the test.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"cbf7982887decc527455dd8f64477813e8ea2672"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <[email protected]>
Fixes #182017
Summary
The PR tries to address the flakiness from the test.