[SecuritySolution][Onboarding] Send Telemetry when header/footer cards are clicked #196495
+186
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusruidiazgd
changed the title
|
/ci |
|
/ci |
agusruidiazgd
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
agusruidiazgd
changed the title
semd
reviewed
Oct 23, 2024
x-pack/plugins/security_solution/public/common/lib/telemetry/constants.ts
Outdated
Show resolved
Hide resolved
angorayc
reviewed
Oct 23, 2024
x-pack/plugins/security_solution/public/common/lib/telemetry/constants.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
angorayc
approved these changes
Oct 23, 2024
|
Telemetry added: Header:
Footer:
|
semd
pushed a commit
to semd/kibana
that referenced
this pull request
Nov 29, 2024
…s are clicked (elastic#196495) ## Summary elastic#196145 To verify: 1. Add these lines to kibana.dev.yml ``` logging.browser.root.level: debug telemetry.optIn: true ``` \ 2. In the onboarding hub, click on header cards. It should log `onboarding_card_${cardId}` on cards clicked. <img width="1101" alt="Screenshot 2024-10-16 at 10 30 58" src="https://github.com/user-attachments/assets/902848f2-fdc5-412d-bfe0-9ed51ba87c56"> <img width="1258" alt="Screenshot 2024-10-15 at 16 54 32" src="https://github.com/user-attachments/assets/883a49a2-cd78-4438-91bb-21b2842b8893"> \ 3. It should log `onboarding_footer_link_${footerLinkId}` on footer links visited. <img width="1019" alt="Screenshot 2024-10-16 at 10 31 26" src="https://github.com/user-attachments/assets/a7ff80a7-a30d-42e9-84d3-5a14fd243022"> <img width="1200" alt="Screenshot 2024-10-15 at 17 29 59" src="https://github.com/user-attachments/assets/3034ca61-425b-47f5-a415-8bf6065f2c6f"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit e38b4df)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
semd
added a commit
that referenced
this pull request
Nov 29, 2024
…r cards are clicked (#196495) (#202309) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution][Onboarding] Send Telemetry when header/footer cards are clicked (#196495)](#196495) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Agustina Nahir Ruidiaz","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T12:42:36Z","message":"[SecuritySolution][Onboarding] Send Telemetry when header/footer cards are clicked (#196495)\n\n## Summary\r\n\r\n#196145\r\n\r\nTo verify:\r\n\r\n\r\n1. Add these lines to kibana.dev.yml\r\n```\r\nlogging.browser.root.level: debug\r\ntelemetry.optIn: true\r\n```\r\n\\\r\n2. In the onboarding hub, click on header cards.\r\nIt should log `onboarding_card_${cardId}` on cards clicked.\r\n<img width=\"1101\" alt=\"Screenshot 2024-10-16 at 10 30 58\"\r\nsrc=\"https://github.com/user-attachments/assets/902848f2-fdc5-412d-bfe0-9ed51ba87c56\">\r\n<img width=\"1258\" alt=\"Screenshot 2024-10-15 at 16 54 32\"\r\nsrc=\"https://github.com/user-attachments/assets/883a49a2-cd78-4438-91bb-21b2842b8893\">\r\n\r\n\\\r\n3. It should log `onboarding_footer_link_${footerLinkId}` on footer\r\nlinks visited.\r\n<img width=\"1019\" alt=\"Screenshot 2024-10-16 at 10 31 26\"\r\nsrc=\"https://github.com/user-attachments/assets/a7ff80a7-a30d-42e9-84d3-5a14fd243022\">\r\n\r\n<img width=\"1200\" alt=\"Screenshot 2024-10-15 at 17 29 59\"\r\nsrc=\"https://github.com/user-attachments/assets/3034ca61-425b-47f5-a415-8bf6065f2c6f\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e38b4df83db4c56a747b88642c7458a88dd10822","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","backport:skip","v9.0.0","Team:Threat Hunting:Explore","ci:cloud-deploy","v8.16.0"],"number":196495,"url":"https://github.com/elastic/kibana/pull/196495","mergeCommit":{"message":"[SecuritySolution][Onboarding] Send Telemetry when header/footer cards are clicked (#196495)\n\n## Summary\r\n\r\n#196145\r\n\r\nTo verify:\r\n\r\n\r\n1. Add these lines to kibana.dev.yml\r\n```\r\nlogging.browser.root.level: debug\r\ntelemetry.optIn: true\r\n```\r\n\\\r\n2. In the onboarding hub, click on header cards.\r\nIt should log `onboarding_card_${cardId}` on cards clicked.\r\n<img width=\"1101\" alt=\"Screenshot 2024-10-16 at 10 30 58\"\r\nsrc=\"https://github.com/user-attachments/assets/902848f2-fdc5-412d-bfe0-9ed51ba87c56\">\r\n<img width=\"1258\" alt=\"Screenshot 2024-10-15 at 16 54 32\"\r\nsrc=\"https://github.com/user-attachments/assets/883a49a2-cd78-4438-91bb-21b2842b8893\">\r\n\r\n\\\r\n3. It should log `onboarding_footer_link_${footerLinkId}` on footer\r\nlinks visited.\r\n<img width=\"1019\" alt=\"Screenshot 2024-10-16 at 10 31 26\"\r\nsrc=\"https://github.com/user-attachments/assets/a7ff80a7-a30d-42e9-84d3-5a14fd243022\">\r\n\r\n<img width=\"1200\" alt=\"Screenshot 2024-10-15 at 17 29 59\"\r\nsrc=\"https://github.com/user-attachments/assets/3034ca61-425b-47f5-a415-8bf6065f2c6f\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e38b4df83db4c56a747b88642c7458a88dd10822"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196495","number":196495,"mergeCommit":{"message":"[SecuritySolution][Onboarding] Send Telemetry when header/footer cards are clicked (#196495)\n\n## Summary\r\n\r\n#196145\r\n\r\nTo verify:\r\n\r\n\r\n1. Add these lines to kibana.dev.yml\r\n```\r\nlogging.browser.root.level: debug\r\ntelemetry.optIn: true\r\n```\r\n\\\r\n2. In the onboarding hub, click on header cards.\r\nIt should log `onboarding_card_${cardId}` on cards clicked.\r\n<img width=\"1101\" alt=\"Screenshot 2024-10-16 at 10 30 58\"\r\nsrc=\"https://github.com/user-attachments/assets/902848f2-fdc5-412d-bfe0-9ed51ba87c56\">\r\n<img width=\"1258\" alt=\"Screenshot 2024-10-15 at 16 54 32\"\r\nsrc=\"https://github.com/user-attachments/assets/883a49a2-cd78-4438-91bb-21b2842b8893\">\r\n\r\n\\\r\n3. It should log `onboarding_footer_link_${footerLinkId}` on footer\r\nlinks visited.\r\n<img width=\"1019\" alt=\"Screenshot 2024-10-16 at 10 31 26\"\r\nsrc=\"https://github.com/user-attachments/assets/a7ff80a7-a30d-42e9-84d3-5a14fd243022\">\r\n\r\n<img width=\"1200\" alt=\"Screenshot 2024-10-15 at 17 29 59\"\r\nsrc=\"https://github.com/user-attachments/assets/3034ca61-425b-47f5-a415-8bf6065f2c6f\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e38b4df83db4c56a747b88642c7458a88dd10822"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Agustina Nahir Ruidiaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#196145
To verify:
2. In the onboarding hub, click on header cards.
It should log
onboarding_card_${cardId}on cards clicked.3. It should log
onboarding_footer_link_${footerLinkId}on footer links visited.Checklist
Delete any items that are not applicable to this PR.