Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Fixes inline casting wrong validation #196489

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 16, 2024

Summary

Part of #192255

Fixes the wrong client side validation error for inline casting cases. For example

FROM logstash-*
| WHERE `clientip`::string=="126.217.11.66"

Checklist

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v9.0.0 v8.16.0 labels Oct 16, 2024
@stratoula stratoula marked this pull request as ready for review October 16, 2024 09:14
@stratoula stratoula requested a review from a team as a code owner October 16, 2024 09:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +2.0B

Copy link
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 🎉

@stratoula stratoula merged commit 40f9513 into elastic:main Oct 16, 2024
35 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11369446904

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 16, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 16, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Fixes inline casting wrong validation
(#196489)](#196489)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T16:01:48Z","message":"[ES|QL]
Fixes inline casting wrong validation
(#196489)","sha":"40f95132e8032787b995bd68d8f265fffea2760e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL]
Fixes inline casting wrong
validation","number":196489,"url":"https://github.com/elastic/kibana/pull/196489","mergeCommit":{"message":"[ES|QL]
Fixes inline casting wrong validation
(#196489)","sha":"40f95132e8032787b995bd68d8f265fffea2760e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196489","number":196489,"mergeCommit":{"message":"[ES|QL]
Fixes inline casting wrong validation
(#196489)","sha":"40f95132e8032787b995bd68d8f265fffea2760e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants