-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Fixes inline casting wrong validation #196489
[ES|QL] Fixes inline casting wrong validation #196489
Conversation
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Page load bundle
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM 🎉
Starting backport for target branches: 8.x |
(cherry picked from commit 40f9513)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Fixes inline casting wrong validation (#196489)](#196489) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T16:01:48Z","message":"[ES|QL] Fixes inline casting wrong validation (#196489)","sha":"40f95132e8032787b995bd68d8f265fffea2760e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL] Fixes inline casting wrong validation","number":196489,"url":"https://github.com/elastic/kibana/pull/196489","mergeCommit":{"message":"[ES|QL] Fixes inline casting wrong validation (#196489)","sha":"40f95132e8032787b995bd68d8f265fffea2760e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196489","number":196489,"mergeCommit":{"message":"[ES|QL] Fixes inline casting wrong validation (#196489)","sha":"40f95132e8032787b995bd68d8f265fffea2760e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
Summary
Part of #192255
Fixes the wrong client side validation error for inline casting cases. For example
Checklist