Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17][SecuritySolution][Endpoint]Remove redundant escape chars from regex #196486

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[7.17][SecuritySolution][Endpoint]Remove redundant escape chars from regex #196486

merged 1 commit into from
Oct 16, 2024

Conversation

ashokaditya
Copy link
Member

Note

For 7.17

Summary

Cleans up redundant escape characters from regex within security_solution plugin (endpoint management)

@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint labels Oct 16, 2024
@ashokaditya ashokaditya self-assigned this Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@ashokaditya ashokaditya added v7.17.0 backport:version Backport to applied version labels backport:skip This commit does not require backporting and removed backport:version Backport to applied version labels labels Oct 16, 2024
@ashokaditya
remove redundant escape chars from regex
36210a6 
fixes errors reported by code scanning process
@ashokaditya ashokaditya force-pushed the task/cleanup-regexp-redundant-escape-1110 branch from 852b3d0 to 36210a6 Compare October 16, 2024 07:53
azasypkin
azasypkin approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the security perspective, thanks!

@ashokaditya
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

There are no new commits on the base branch.

@ashokaditya ashokaditya enabled auto-merge (squash) October 16, 2024 10:41
@dasansol92 dasansol92 disabled auto-merge October 16, 2024 10:52
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Cypress Tests #15 / Detections > Callouts indicating read-only access to resources On Detections home page "before all" hook for "We show one primary callout"

Metrics [docs]

✅ unchanged

History

  • 💔 Build #242958 failed 852b3d012701c9c405af0094b705b4ea1cfd40c7

cc @ashokaditya

@ashokaditya ashokaditya merged commit 427e952 into elastic:7.17 Oct 16, 2024
31 checks passed
@ashokaditya ashokaditya deleted the task/cleanup-regexp-redundant-escape-1110 branch October 16, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

@dasansol92 dasansol92 Awaiting requested review from dasansol92

@gergoabraham gergoabraham Awaiting requested review from gergoabraham

Assignees

@ashokaditya ashokaditya

Labels
backport:skip This commit does not require backporting OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashokaditya @elasticmachine @azasypkin