-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error handling/retry logic for search source alert tests #196443
Merged
lukasolson
merged 16 commits into
elastic:main
from
lukasolson:search_source_alert_ft_error_handling
Dec 10, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4a0eefa
Add error handling/retry logic for search source alert tests
lukasolson 62a04a2
Merge branch 'main' into search_source_alert_ft_error_handling
lukasolson 7472416
Merge branch 'main' into search_source_alert_ft_error_handling
lukasolson be39271
Merge branch 'main' into search_source_alert_ft_error_handling
lukasolson 2f76e19
Merge branch 'search_source_alert_ft_error_handling' of github.com:lu…
lukasolson 7ef8a68
Merge branch 'main' into search_source_alert_ft_error_handling
lukasolson cc4367f
Fix data-test-subj for MKI tests
lukasolson f38bb92
Merge remote-tracking branch 'upstream/main' into search_source_alert…
lukasolson e8450f2
Merge branch 'main' into search_source_alert_ft_error_handling
lukasolson 4a09619
Merge branch 'main' into search_source_alert_ft_error_handling
lukasolson 2eddc47
Merge branch 'main' into search_source_alert_ft_error_handling
lukasolson e79b705
Merge branch 'main' of github.com:elastic/kibana into search_source_a…
lukasolson 61540ad
Skip actual failing test
lukasolson 96fc8ba
Merge branch 'search_source_alert_ft_error_handling' of github.com:lu…
lukasolson 3cfd4ff
skip alert tests on serverless observability
lukasolson dd053d4
Merge branch 'main' into search_source_alert_ft_error_handling
lukasolson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the conditionals for buttons and inputs are for O11y projects? We should probably consider splitting these out since they could diverge more, but let's get them unskipped for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, and yes I totally agree. There was already conditionals like these in these tests but I agree, it's probably time now to split these.