[Security Solution] Document details flyout - fix session view alerts error #196422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:fix
v9.0.0
Team:Threat Hunting
...ins/security_solution/public/timelines/components/timeline/tabs/session/use_session_view.tsx
Show resolved
Hide resolved
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
approved these changes
Oct 16, 2024
💔 Build Failed
Failed CI StepsHistory
|
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
… error (elastic#196422) ## Summary Related elastic#191582 We passed indices to session viewer based on sourcerer scope. When user is in a non-alert page, the alerts index is not available and hence session viewer throws an error when a user tries to open alert details. This PR updates indices to always be the alerts indices. https://github.com/user-attachments/assets/264865f9-0bff-44f1-9dda-4bcd91eeab4a (cherry picked from commit 89d833b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
… error (elastic#196422) ## Summary Related elastic#191582 We passed indices to session viewer based on sourcerer scope. When user is in a non-alert page, the alerts index is not available and hence session viewer throws an error when a user tries to open alert details. This PR updates indices to always be the alerts indices. https://github.com/user-attachments/assets/264865f9-0bff-44f1-9dda-4bcd91eeab4a (cherry picked from commit 89d833b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
… alerts error (#196422) (#196758) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] Document details flyout - fix session view alerts error (#196422)](#196422) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T18:26:57Z","message":"[Security Solution] Document details flyout - fix session view alerts error (#196422)\n\n## Summary\r\n\r\nRelated https://github.com/elastic/kibana/issues/191582\r\n\r\nWe passed indices to session viewer based on sourcerer scope. When user\r\nis in a non-alert page, the alerts index is not available and hence\r\nsession viewer throws an error when a user tries to open alert details.\r\nThis PR updates indices to always be the alerts indices.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/264865f9-0bff-44f1-9dda-4bcd91eeab4a","sha":"89d833bf58ba614a0e9eb6a38a02c4eb5a641aeb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:fix","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution] Document details flyout - fix session view alerts error","number":196422,"url":"https://github.com/elastic/kibana/pull/196422","mergeCommit":{"message":"[Security Solution] Document details flyout - fix session view alerts error (#196422)\n\n## Summary\r\n\r\nRelated https://github.com/elastic/kibana/issues/191582\r\n\r\nWe passed indices to session viewer based on sourcerer scope. When user\r\nis in a non-alert page, the alerts index is not available and hence\r\nsession viewer throws an error when a user tries to open alert details.\r\nThis PR updates indices to always be the alerts indices.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/264865f9-0bff-44f1-9dda-4bcd91eeab4a","sha":"89d833bf58ba614a0e9eb6a38a02c4eb5a641aeb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196422","number":196422,"mergeCommit":{"message":"[Security Solution] Document details flyout - fix session view alerts error (#196422)\n\n## Summary\r\n\r\nRelated https://github.com/elastic/kibana/issues/191582\r\n\r\nWe passed indices to session viewer based on sourcerer scope. When user\r\nis in a non-alert page, the alerts index is not available and hence\r\nsession viewer throws an error when a user tries to open alert details.\r\nThis PR updates indices to always be the alerts indices.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/264865f9-0bff-44f1-9dda-4bcd91eeab4a","sha":"89d833bf58ba614a0e9eb6a38a02c4eb5a641aeb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
…alerts error (#196422) (#196759) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Document details flyout - fix session view alerts error (#196422)](#196422) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T18:26:57Z","message":"[Security Solution] Document details flyout - fix session view alerts error (#196422)\n\n## Summary\r\n\r\nRelated https://github.com/elastic/kibana/issues/191582\r\n\r\nWe passed indices to session viewer based on sourcerer scope. When user\r\nis in a non-alert page, the alerts index is not available and hence\r\nsession viewer throws an error when a user tries to open alert details.\r\nThis PR updates indices to always be the alerts indices.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/264865f9-0bff-44f1-9dda-4bcd91eeab4a","sha":"89d833bf58ba614a0e9eb6a38a02c4eb5a641aeb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:fix","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution] Document details flyout - fix session view alerts error","number":196422,"url":"https://github.com/elastic/kibana/pull/196422","mergeCommit":{"message":"[Security Solution] Document details flyout - fix session view alerts error (#196422)\n\n## Summary\r\n\r\nRelated https://github.com/elastic/kibana/issues/191582\r\n\r\nWe passed indices to session viewer based on sourcerer scope. When user\r\nis in a non-alert page, the alerts index is not available and hence\r\nsession viewer throws an error when a user tries to open alert details.\r\nThis PR updates indices to always be the alerts indices.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/264865f9-0bff-44f1-9dda-4bcd91eeab4a","sha":"89d833bf58ba614a0e9eb6a38a02c4eb5a641aeb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196422","number":196422,"mergeCommit":{"message":"[Security Solution] Document details flyout - fix session view alerts error (#196422)\n\n## Summary\r\n\r\nRelated https://github.com/elastic/kibana/issues/191582\r\n\r\nWe passed indices to session viewer based on sourcerer scope. When user\r\nis in a non-alert page, the alerts index is not available and hence\r\nsession viewer throws an error when a user tries to open alert details.\r\nThis PR updates indices to always be the alerts indices.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/264865f9-0bff-44f1-9dda-4bcd91eeab4a","sha":"89d833bf58ba614a0e9eb6a38a02c4eb5a641aeb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related #191582
We passed indices to session viewer based on sourcerer scope. When user is in a non-alert page, the alerts index is not available and hence session viewer throws an error when a user tries to open alert details. This PR updates indices to always be the alerts indices.
Screen.Recording.2024-10-15.at.1.06.46.PM.mov