Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Bash #196393

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Bash #196393

merged 1 commit into from
Oct 16, 2024

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Oct 15, 2024 •
edited by kibanamachine
Loading

Summary

This PR is to address the small UI enhancements for Contextual Flyouts
Screenshot 2024-10-15 at 10 10 20 AM
Screenshot 2024-10-15 at 10 10 52 AM

List of UI updates:

  • Fixed Color for Misconfiguration and Vulneabilities Preview Title
  • Fixed Size and Font for Posture Score text in Misconfiguration Preview component and Vulnerabilities in Vulnerabilities Preview component
  • Fixed Size for number in Misconfiguration Preview and Vulnerabilities Preview component
  • Fixed Paddings for Misconfiguration and Vulnerabilities Preview component
  • Fixed Padding between 2 preview components
  • Fixed Width size for severity column

@animehart animehart changed the title Contextual Flyout small UI updates [Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt Oct 15, 2024
@animehart animehart marked this pull request as ready for review October 15, 2024 17:13
@animehart animehart requested a review from a team as a code owner October 15, 2024 17:13
@animehart animehart added the Team:Cloud Security Cloud Security team related label Oct 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0 labels Oct 15, 2024
@animehart animehart linked an issue Oct 15, 2024 that may be closed by this pull request
[Cloud Security][Bug] Contextual Flyout Improvements #196260
Closed
6 tasks
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #37 / task_manager migrations "before all" hook for "8.0.0 migrates actions tasks with legacy id to saved object ids"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.8MB 20.8MB -100.0B

@animehart animehart merged commit f049dc0 into elastic:main Oct 16, 2024
75 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11362140135

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 16, 2024
@animehart
[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt (ela…
9d55e60 
…stic#196393)

## Summary

This PR is to address the small UI enhancements for Contextual Flyouts
<img width="649" alt="Screenshot 2024-10-15 at 10 10 20 AM"
src="https://github.com/user-attachments/assets/f4a1dbf1-8800-4060-8674-2318c21a9b58">
<img width="801" alt="Screenshot 2024-10-15 at 10 10 52 AM"
src="https://github.com/user-attachments/assets/e2fdfaed-1b2a-4d66-af6e-420cbf1a26c7">

List of UI updates:
-  Fixed Color for Misconfiguration and Vulneabilities Preview Title
- Fixed Size and Font for Posture Score text in Misconfiguration Preview
component and Vulnerabilities in Vulnerabilities Preview component
- Fixed Size for number in Misconfiguration Preview and Vulnerabilities
Preview component
- Fixed Paddings for Misconfiguration and Vulnerabilities Preview
component
-  Fixed Padding between 2 preview components
-  Fixed Width size for severity column

(cherry picked from commit f049dc0)
@kibanamachine kibanamachine mentioned this pull request Oct 16, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 16, 2024
@kibanamachine @animehart
[8.x] [Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt (
c986220 
#196393) (#196499)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt
(#196393)](#196393)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rickyanto
Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T08:45:56Z","message":"[Cloud
Security] Fix for Contextual Flyout UI bugs from Bug Hunt
(#196393)\n\n## Summary\r\n\r\nThis PR is to address the small UI
enhancements for Contextual Flyouts\r\n<img width=\"649\"
alt=\"Screenshot 2024-10-15 at 10 10
20 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/f4a1dbf1-8800-4060-8674-2318c21a9b58\">\r\n<img
width=\"801\" alt=\"Screenshot 2024-10-15 at 10 10
52 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/e2fdfaed-1b2a-4d66-af6e-420cbf1a26c7\">\r\n\r\nList
of UI updates:\r\n- Fixed Color for Misconfiguration and Vulneabilities
Preview Title\r\n- Fixed Size and Font for Posture Score text in
Misconfiguration Preview\r\ncomponent and Vulnerabilities in
Vulnerabilities Preview component\r\n- Fixed Size for number in
Misconfiguration Preview and Vulnerabilities\r\nPreview component\r\n-
Fixed Paddings for Misconfiguration and Vulnerabilities
Preview\r\ncomponent\r\n- Fixed Padding between 2 preview
components\r\n- Fixed Width size for severity
column","sha":"f049dc048d910293ddb880f98b155fb35ce3120f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud
Security","backport:prev-minor","v8.16.0"],"title":"[Cloud Security] Fix
for Contextual Flyout UI bugs from Bug
Hunt","number":196393,"url":"https://github.com/elastic/kibana/pull/196393","mergeCommit":{"message":"[Cloud
Security] Fix for Contextual Flyout UI bugs from Bug Hunt
(#196393)\n\n## Summary\r\n\r\nThis PR is to address the small UI
enhancements for Contextual Flyouts\r\n<img width=\"649\"
alt=\"Screenshot 2024-10-15 at 10 10
20 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/f4a1dbf1-8800-4060-8674-2318c21a9b58\">\r\n<img
width=\"801\" alt=\"Screenshot 2024-10-15 at 10 10
52 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/e2fdfaed-1b2a-4d66-af6e-420cbf1a26c7\">\r\n\r\nList
of UI updates:\r\n- Fixed Color for Misconfiguration and Vulneabilities
Preview Title\r\n- Fixed Size and Font for Posture Score text in
Misconfiguration Preview\r\ncomponent and Vulnerabilities in
Vulnerabilities Preview component\r\n- Fixed Size for number in
Misconfiguration Preview and Vulnerabilities\r\nPreview component\r\n-
Fixed Paddings for Misconfiguration and Vulnerabilities
Preview\r\ncomponent\r\n- Fixed Padding between 2 preview
components\r\n- Fixed Width size for severity
column","sha":"f049dc048d910293ddb880f98b155fb35ce3120f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196393","number":196393,"mergeCommit":{"message":"[Cloud
Security] Fix for Contextual Flyout UI bugs from Bug Hunt
(#196393)\n\n## Summary\r\n\r\nThis PR is to address the small UI
enhancements for Contextual Flyouts\r\n<img width=\"649\"
alt=\"Screenshot 2024-10-15 at 10 10
20 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/f4a1dbf1-8800-4060-8674-2318c21a9b58\">\r\n<img
width=\"801\" alt=\"Screenshot 2024-10-15 at 10 10
52 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/e2fdfaed-1b2a-4d66-af6e-420cbf1a26c7\">\r\n\r\nList
of UI updates:\r\n- Fixed Color for Misconfiguration and Vulneabilities
Preview Title\r\n- Fixed Size and Font for Posture Score text in
Misconfiguration Preview\r\ncomponent and Vulnerabilities in
Vulnerabilities Preview component\r\n- Fixed Size for number in
Misconfiguration Preview and Vulnerabilities\r\nPreview component\r\n-
Fixed Paddings for Misconfiguration and Vulnerabilities
Preview\r\ncomponent\r\n- Fixed Padding between 2 preview
components\r\n- Fixed Width size for severity
column","sha":"f049dc048d910293ddb880f98b155fb35ce3120f"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rickyanto Ang <[email protected]>
@animehart animehart added backport:version Backport to applied version labels backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels labels Oct 19, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16

https://github.com/elastic/kibana/actions/runs/11416132173

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11416134219

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.16 Cherrypick failed because the selected commit (f049dc0) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

node scripts/backport --pr 196393

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.16 Cherrypick failed because the selected commit (f049dc0) is empty. Did you already backport this commit?
❌ 8.x Cherrypick failed because the selected commit (f049dc0) is empty. It looks like the commit was already backported in #196499

Manual backport

To create the backport manually run:

node scripts/backport --pr 196393

Questions ?

Please refer to the Backport tool documentation

@opauloh opauloh changed the title [Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt [Cloud Security] Fix for Contextual Flyout UI bugs from Bug Bash Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanSh JordanSh JordanSh approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security][Bug] Contextual Flyout Improvements
4 participants
@animehart @elasticmachine @kibanamachine @JordanSh