-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Remove auto-creation of default monitor status and TLS alerts #196391
base: main
Are you sure you want to change the base?
Conversation
16b908a
to
9eda881
Compare
9eda881
to
ff37e75
Compare
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
x-pack/plugins/alerting/server/routes/rule/apis/find/find_rules_route.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/server/routes/rule/apis/find/find_rules_route.ts
Outdated
Show resolved
Hide resolved
4dec151
to
2773205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would only display this if there is a DEFAULT rule present. The default connectors are irrelevant if there isn't any default rules. For example, if the user is only using custom rules, configuring default connectors is irrelevant.
In my opinion, this button should navigate to the observability rules management page
...on/synthetics/public/apps/synthetics/components/common/alerting_callout/alerting_callout.tsx
Outdated
Show resolved
Hide resolved
...on/synthetics/public/apps/synthetics/components/common/alerting_callout/alerting_callout.tsx
Outdated
Show resolved
Hide resolved
...on/synthetics/public/apps/synthetics/components/common/alerting_callout/alerting_callout.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click on "create custom rule" and it's created, the callout remains until I refresh the page.
2773205
to
9d635f8
Compare
💔 Build Failed
Failed CI StepsHistory
|
Summary
Resolves #193610.
This PR overhauls the way that we check for rules to display in the UI. This is necessitated because we are no longer automatically generating rules, and the global rules we can use are of the same type as the customizable rules users can define.
UI changes
This is very similar to what we already do, but the method of querying the data has changed, and it's stored in the application state now.
Backend changes
Users can still create the default alerts, and thus the API for this is still present, but it's not called by default anymore. If the user navigates to Synthetics and starts creating monitors, they'll eventually be prompted by the callouts above. We do plan to follow this up with a better UI experience, which we have designs for, but I will create that as an enhancement ticket linked to this one that we can prioritize later. These changes are largely in line with what the current experience is, so this is not regressive.
We have also removed
defaultStatusRuleEnabled
anddefaultTLSRuleEnabled
from the settings saved object definition, per the requirements in the linked ticket.Checklist co-opted from the linked issue
defaultStatusRuleEnabled
anddefaultTlsRuleEnabled
) within the Synthetics saved object should be removed from the code base, particularly from thedefault_alert_service.ts
file.Code is WIP.