Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds E5 disclaimer to the trained models flyout #196347

Merged
merged 5 commits into from
Oct 16, 2024
Merged

[ML] Adds E5 disclaimer to the trained models flyout #196347

merged 5 commits into from
Oct 16, 2024

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Oct 15, 2024 •
edited by kibanamachine
Loading

Summary

Adds E5 disclaimer to the "Add model" flyout.

image

@darnautov darnautov requested a review from a team as a code owner October 15, 2024 15:23
@darnautov darnautov added :ml release_note:skip Skip the PR/issue when compiling release notes labels Oct 15, 2024
@darnautov darnautov self-assigned this Oct 15, 2024
@darnautov darnautov added v9.0.0 Team:ML Team label for ML (also use :ml) v8.16.0 backport:version Backport to applied version labels labels Oct 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov enabled auto-merge (squash) October 15, 2024 15:29
@peteharverson peteharverson changed the title [ML] E5 discplaimer in the flyout [ML] E5 disclaimer in the flyout Oct 15, 2024
@peteharverson peteharverson changed the title [ML] E5 disclaimer in the flyout [ML] Adds E5 disclaimer to the trained models flyout Oct 15, 2024
@peteharverson peteharverson added the Feature:3rd Party Models ML 3rd party models label Oct 15, 2024
peteharverson
peteharverson approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov merged commit 8bd567b into elastic:main Oct 16, 2024
32 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11369651291

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.5MB 4.5MB +21.0B

History

cc @darnautov

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 16, 2024
@darnautov
[ML] E5 discplaimer in the flyout (elastic#196347)
2acde9f 
## Summary

Adds E5 disclaimer to the "Add model" flyout.

<img width="1320" alt="image"
src="https://github.com/user-attachments/assets/3c46a7ea-91c1-4bf2-8671-dc7df283c09c">

(cherry picked from commit 8bd567b)
@kibanamachine kibanamachine mentioned this pull request Oct 16, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 16, 2024
@kibanamachine @darnautov
[8.x] [ML] E5 discplaimer in the flyout (#196347) (#196574)
20c366a 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] E5 discplaimer in the flyout
(#196347)](#196347)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T16:14:04Z","message":"[ML]
E5 discplaimer in the flyout (#196347)\n\n## Summary\r\n\r\nAdds E5
disclaimer to the \"Add model\" flyout. \r\n\r\n<img width=\"1320\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3c46a7ea-91c1-4bf2-8671-dc7df283c09c\">","sha":"8bd567b73a1b4385cfcfac26f7d18142a3b76a5d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Feature:3rd
Party Models","Team:ML","v8.16.0","backport:version"],"title":"[ML] Adds
E5 disclaimer to the trained models flyout
","number":196347,"url":"https://github.com/elastic/kibana/pull/196347","mergeCommit":{"message":"[ML]
E5 discplaimer in the flyout (#196347)\n\n## Summary\r\n\r\nAdds E5
disclaimer to the \"Add model\" flyout. \r\n\r\n<img width=\"1320\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3c46a7ea-91c1-4bf2-8671-dc7df283c09c\">","sha":"8bd567b73a1b4385cfcfac26f7d18142a3b76a5d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196347","number":196347,"mergeCommit":{"message":"[ML]
E5 discplaimer in the flyout (#196347)\n\n## Summary\r\n\r\nAdds E5
disclaimer to the \"Add model\" flyout. \r\n\r\n<img width=\"1320\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3c46a7ea-91c1-4bf2-8671-dc7df283c09c\">","sha":"8bd567b73a1b4385cfcfac26f7d18142a3b76a5d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Oct 17, 2024
@darnautov @hop-dev
[ML] E5 discplaimer in the flyout (elastic#196347)
7776499 
## Summary

Adds E5 disclaimer to the "Add model" flyout. 

<img width="1320" alt="image"
src="https://github.com/user-attachments/assets/3c46a7ea-91c1-4bf2-8671-dc7df283c09c">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
backport:version Backport to applied version labels Feature:3rd Party Models ML 3rd party models :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darnautov @elasticmachine @kibanamachine @peteharverson