Obsolete PR #196338

JoseLuisGJ · 2024-10-15T14:58:24Z

This PR was moved to this one: #199284

JoseLuisGJ

I commented some concerns there @sphilipse

x-pack/plugins/serverless_search/public/application/components/connectors_router.tsx

x-pack/plugins/serverless_search/public/navigation_tree.ts

x-pack/plugins/serverless_search/public/plugin.ts

x-pack/plugins/serverless_search/public/application/components/web_crawlers_router.tsx

sphilipse

Thanks Jose! I added a bunch of comments, some of these are just reminders so that we don't forget to fix these things before merging.

...ss_search/public/application/components/connectors/elastic_managed_connector_coming_soon.tsx

...earch/public/application/components/web_crawlers/elastic_managed_web_crawler_coming_soon.tsx

sphilipse · 2024-10-21T09:43:25Z

...earch/public/application/components/web_crawlers/elastic_managed_web_crawler_coming_soon.tsx

+              <EuiButtonEmpty
+                data-test-subj="serverlessSearchElasticManagedWebCrawlerEmptyBackButton"
+                iconType="arrowLeft"
+                onClick={() => navigateToUrl(`./`)}


We shouldn't be navigating back this way, but by explicitly going to a complete URL.

sphilipse · 2024-10-21T09:46:18Z

...earch/public/application/components/web_crawlers/elastic_managed_web_crawler_coming_soon.tsx

+                  <EuiFlexItem grow={false}>
+                    <EuiStepsHorizontal
+                      css={css`
+                        pointer-events: none;


Don't disable a pointer shape using CSS: these items are still interactive and clickable. People using screenreaders or tabbing through will still see these steps as interactive. If you want the visual element of steps but no interactivity, you should find a different solution than using interactive elements.

I've been discussing this issue with the EUI team. And this a11y issue can be avoid using the inert HTML attribute to prevent click and focus events for all this content. In addition using the role="presentation" attribute we don't expose it to the accessibility tree.

With all that <EuiStepsHorizontal> component is not interactive with either the keyboard or the mouse:

<EuiStepsHorizontal css={css` pointer-events: none; `} steps={horizontalSteps} size="s" role="presentation" // @ts-ignore inert="" />

x-pack/plugins/serverless_search/public/application/components/web_crawlers_overview.tsx

sphilipse · 2024-10-21T09:53:42Z

x-pack/plugins/serverless_search/public/application/components/web_crawlers_elastic_managed.tsx

@@ -0,0 +1,64 @@
+/*


These next two components are extremely similar. We can probably combine them into one component, that just takes some inputs

sphilipse · 2024-10-21T09:54:48Z

x-pack/plugins/serverless_search/public/application/constants.ts

 export const FILE_UPLOAD_PATH = '/app/ml/filedatavisualizer';
+
+export const CRAWLER = {


Are you expecting to add more things to these objects? Otherwise I would just export two constants called CRAWLER_GITHUB_LINK and CONNECTORS_GITHUB_LINK

For now I'm getting these values to be centrilised:

export const CRAWLER = { github_repo: 'https://github.com/elastic/crawler', docker_doc: 'https://github.com/elastic/crawler?tab=readme-ov-file#running-open-crawler-with-docker', }; export const CONNECTORS = { github_repo: 'https://github.com/elastic/connectors', self_managed_docs: 'https://www.elastic.co/docs/current/serverless/elasticsearch/ingest-data-through-integrations-connector-client', docker_doc: 'https://github.com/elastic/connectors/blob/main/scripts/stack/README.md', };

x-pack/plugins/serverless_search/public/navigation_tree.ts

x-pack/plugins/serverless_search/public/plugin.ts

x-pack/plugins/serverless_search/public/application/components/web_crawlers_router.tsx

x-pack/plugins/serverless_search/public/application/components/connectors_overview.tsx

sphilipse · 2024-10-21T11:17:30Z

x-pack/plugins/serverless_search/public/application/constants.ts

 export const EDIT_CONNECTOR_PATH = `${BASE_CONNECTORS_PATH}/:id`;
+export const ELASTIC_MANAGED_CONNECTOR_PATH = '/elastic_managed';


Better to construct these the way the edit connector path above is constructed

If I modify these constants in this:

export const ELASTIC_MANAGED_CONNECTOR_PATH = `${BASE_CONNECTORS_PATH}/elastic_managed`; export const ELASTIC_MANAGED_WEB_CRAWLERS_PATH = `${BASE_WEB_CRAWLERS_PATH}/elastic_managed`;

Consuming them from the connectors_router.tsx like:

<Route exact path={ELASTIC_MANAGED_CONNECTOR_PATH}> <ConnectorsElasticManaged /> </Route>

Generates a non working route URL:

http://localhost:5601/app/connectors/connectors/elastic_managed

With a duplicated connectors/connectors...

sphilipse · 2024-10-21T11:21:36Z

...ss_search/public/application/components/connectors/elastic_managed_connector_coming_soon.tsx

@@ -0,0 +1,367 @@
+/*


Both this component and the elastic managed web crawlers component have a lot of stuff in common. Instead of duplicating tons of code, we should find ways to re-use some.

...ss_search/public/application/components/connectors/elastic_managed_connector_coming_soon.tsx

sphilipse · 2024-10-21T11:34:06Z

x-pack/plugins/serverless_search/public/application/components/connectors_elastic_managed.tsx

+
+import { CONNECTORS } from '../constants';
+
+export const ConnectorsElasticManaged = () => {


Why is there a full connectors managed page here? We don't have any elastic managed connectors yet, and you're create connector creates a non-managed connector.

This page aims for rendering the Coming soon page content for connectors as we do also with Web Crawlers. Consuming the and rendering as children the

<EuiPageTemplate.Section restrictWidth color="subdued"> <ElasticManagedConnectorComingSoon /> </EuiPageTemplate.Section>

We want to track how many users open this page so I guess this is the way to do it and get a dedicated URL route for this. But let me know if there is another way I should take care of.

x-pack/plugins/serverless_search/public/application/components/connectors_router.tsx

…onal EuiStepsHorizontal

…-fix'

elasticmachine · 2024-11-06T13:58:53Z

💔 Build Failed

Buildkite Build
Commit: fa2a15d

Failed CI Steps

History

💔 Build #248822 failed c64ca3f
💔 Build #244184 failed b35e475

cc @JoseLuisGJ

elasticmachine · 2024-11-06T14:35:12Z

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

Click to trigger kibana-pull-request for this PR!
Click to trigger kibana-deploy-project-from-pr for this PR!

This reverts commit c64ca3f, reversing changes made to 5e57f28.

JoseLuisGJ added 4 commits October 15, 2024 13:32

Connectors empty state with coming soon content

2fc9e91

Elastic managed connector coming soon page layout

8b32725

Web crawlers coming soon pages

46ac3df

Callout asking for give feedback

b35e475

JoseLuisGJ self-assigned this Oct 17, 2024

JoseLuisGJ requested a review from sphilipse October 18, 2024 13:55

JoseLuisGJ marked this pull request as ready for review October 21, 2024 09:31

JoseLuisGJ requested a review from a team as a code owner October 21, 2024 09:31

JoseLuisGJ marked this pull request as draft October 21, 2024 09:33

JoseLuisGJ marked this pull request as ready for review October 21, 2024 09:34

JoseLuisGJ marked this pull request as draft October 21, 2024 09:34

JoseLuisGJ commented Oct 21, 2024

View reviewed changes

sphilipse reviewed Oct 21, 2024

View reviewed changes

JoseLuisGJ added 12 commits November 4, 2024 08:53

Adding Serverless Web Crawlers as a Deep link ID

1c5c1f3

Code cleaning

d05e858

Static connector icons

a400f7c

Web crawler docs

5989746

Connectors doc links

fa49ca8

Some content and translation fixes

9868d5f

Cleaning of unused conditional rendering content

da45e21

Code cleaning and content fixes

bea16db

Dismissable Callout

c32c1e8

Using inert attr to prevent focus and click events for the presentati…

4076d3e

…onal EuiStepsHorizontal

Adding role presentational for decorative EuiStepsHorizontal components

5ef32a3

Abstraction and hiding of the Feedback form

5e57f28

JoseLuisGJ marked this pull request as ready for review November 6, 2024 13:14

JoseLuisGJ and others added 2 commits November 6, 2024 14:22

Merge branch 'main' into coming-soon-pages

c64ca3f

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

fa2a15d

…-fix'

JoseLuisGJ marked this pull request as draft November 6, 2024 14:35

Revert "Merge branch 'main' into coming-soon-pages"

37d1431

This reverts commit c64ca3f, reversing changes made to 5e57f28.

JoseLuisGJ changed the title ~~[Search][ES3][Coming soon pages] Connectors and Web crawlers coming soon pages~~ Obsolete PR Nov 7, 2024

sphilipse closed this Nov 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Obsolete PR #196338

Obsolete PR #196338

JoseLuisGJ commented Oct 15, 2024 •

edited

Loading

JoseLuisGJ left a comment

sphilipse left a comment

sphilipse Oct 21, 2024

sphilipse Oct 21, 2024

JoseLuisGJ Nov 6, 2024 •

edited

Loading

sphilipse Oct 21, 2024

sphilipse Oct 21, 2024

JoseLuisGJ Nov 5, 2024

sphilipse Oct 21, 2024

JoseLuisGJ Nov 5, 2024

sphilipse Oct 21, 2024

sphilipse Oct 21, 2024

JoseLuisGJ Nov 5, 2024

elasticmachine commented Nov 6, 2024 •

edited

Loading

elasticmachine commented Nov 6, 2024

		export const FILE_UPLOAD_PATH = '/app/ml/filedatavisualizer';

		export const CRAWLER = {

		export const EDIT_CONNECTOR_PATH = `${BASE_CONNECTORS_PATH}/:id`;
		export const ELASTIC_MANAGED_CONNECTOR_PATH = '/elastic_managed';


		import { CONNECTORS } from '../constants';

		export const ConnectorsElasticManaged = () => {

Obsolete PR #196338

Obsolete PR #196338

Conversation

JoseLuisGJ commented Oct 15, 2024 • edited Loading

JoseLuisGJ left a comment

Choose a reason for hiding this comment

sphilipse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoseLuisGJ Nov 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Nov 6, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

History

elasticmachine commented Nov 6, 2024

JoseLuisGJ commented Oct 15, 2024 •

edited

Loading

JoseLuisGJ Nov 6, 2024 •

edited

Loading

elasticmachine commented Nov 6, 2024 •

edited

Loading