Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI Assistant] Set scope and rename to Observability and Search #196322

Merged

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Oct 15, 2024

Summary

This renames the Observability AI Assistant in some places to AI Assistant for Observability and Search. It also makes the scope multi-valued on both sides.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 labels Oct 15, 2024
@sphilipse sphilipse requested review from a team as code owners October 15, 2024 14:09
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Oct 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@sphilipse sphilipse added backport:version Backport to applied version labels v8.17.0 and removed Team:Obs AI Assistant Observability AI Assistant ci:project-deploy-observability Create an Observability project labels Oct 15, 2024
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Oct 15, 2024
@neptunian
Copy link
Contributor

There will be an error trying to save the new setting unless its added to the serverless allow list. eg: #190098

@neptunian
Copy link
Contributor

This is an existing UI issue for dropdowns where the dropdown doesnt select the default value. Here i am in the observability project using default values and first items in the dropdown show instead.
Screenshot 2024-10-15 at 12 13 22 PM

@jloleysens jloleysens removed the request for review from a team October 16, 2024 11:17
@sphilipse sphilipse requested a review from a team as a code owner October 21, 2024 15:58
@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Oct 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / Timeline esql tab existing esql query is present should show the esql tab when the advanced setting is disabled

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityAIAssistant 296 294 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 91.3KB 91.3KB +11.0B
observabilityAIAssistant 19.2KB 19.1KB -124.0B
observabilityAIAssistantApp 238.7KB 238.7KB +44.0B
observabilityAiAssistantManagement 91.4KB 91.4KB +8.0B
searchAssistant 179.7KB 179.7KB +45.0B
total -16.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 46.9KB 46.9KB +13.0B
observabilityAiAssistantManagement 5.0KB 5.0KB +22.0B
serverlessObservability 27.2KB 27.2KB +11.0B
total +46.0B
Unknown metric groups

API count

id before after diff
observabilityAIAssistant 298 296 -2

History

@sphilipse sphilipse merged commit 26ec293 into elastic:main Oct 24, 2024
30 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11498132583

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
…tic#196322)

## Summary

This renames the Observability AI Assistant in some places to AI
Assistant for Observability and Search. It also makes the scope
multi-valued on both sides.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 26ec293)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
…tic#196322)

## Summary

This renames the Observability AI Assistant in some places to AI
Assistant for Observability and Search. It also makes the scope
multi-valued on both sides.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 26ec293)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
…#196322) (#197609)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[AI Assistant] Set scope and rename to Observability and Search
(#196322)](#196322)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T11:13:43Z","message":"[AI
Assistant] Set scope and rename to Observability and Search
(#196322)\n\n## Summary\r\n\r\nThis renames the Observability AI
Assistant in some places to AI\r\nAssistant for Observability and
Search. It also makes the scope\r\nmulti-valued on both
sides.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"26ec293f07a990930c4caf9765d79882723dbfa6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","Team:Obs
AI
Assistant","ci:project-deploy-observability","Team:obs-ux-infra_services","apm:review","v8.16.0","backport:version","v8.17.0"],"title":"[AI
Assistant] Set scope and rename to Observability and
Search","number":196322,"url":"https://github.com/elastic/kibana/pull/196322","mergeCommit":{"message":"[AI
Assistant] Set scope and rename to Observability and Search
(#196322)\n\n## Summary\r\n\r\nThis renames the Observability AI
Assistant in some places to AI\r\nAssistant for Observability and
Search. It also makes the scope\r\nmulti-valued on both
sides.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"26ec293f07a990930c4caf9765d79882723dbfa6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196322","number":196322,"mergeCommit":{"message":"[AI
Assistant] Set scope and rename to Observability and Search
(#196322)\n\n## Summary\r\n\r\nThis renames the Observability AI
Assistant in some places to AI\r\nAssistant for Observability and
Search. It also makes the scope\r\nmulti-valued on both
sides.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"26ec293f07a990930c4caf9765d79882723dbfa6"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Oct 28, 2024
#196322) (#197608)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[AI Assistant] Set scope and rename to Observability and Search
(#196322)](#196322)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T11:13:43Z","message":"[AI
Assistant] Set scope and rename to Observability and Search
(#196322)\n\n## Summary\r\n\r\nThis renames the Observability AI
Assistant in some places to AI\r\nAssistant for Observability and
Search. It also makes the scope\r\nmulti-valued on both
sides.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"26ec293f07a990930c4caf9765d79882723dbfa6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","Team:Obs
AI
Assistant","ci:project-deploy-observability","Team:obs-ux-infra_services","apm:review","v8.16.0","backport:version","v8.17.0"],"title":"[AI
Assistant] Set scope and rename to Observability and
Search","number":196322,"url":"https://github.com/elastic/kibana/pull/196322","mergeCommit":{"message":"[AI
Assistant] Set scope and rename to Observability and Search
(#196322)\n\n## Summary\r\n\r\nThis renames the Observability AI
Assistant in some places to AI\r\nAssistant for Observability and
Search. It also makes the scope\r\nmulti-valued on both
sides.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"26ec293f07a990930c4caf9765d79882723dbfa6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196322","number":196322,"mergeCommit":{"message":"[AI
Assistant] Set scope and rename to Observability and Search
(#196322)\n\n## Summary\r\n\r\nThis renames the Observability AI
Assistant in some places to AI\r\nAssistant for Observability and
Search. It also makes the scope\r\nmulti-valued on both
sides.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"26ec293f07a990930c4caf9765d79882723dbfa6"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:Search v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants