Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React@18 failing test] fix visualize app - new charts library visualize area charts date histogram when no time filter interval errors should show error when calendar interval invalid #196308

Merged
merged 4 commits into from
Oct 22, 2024
Merged

[React@18 failing test] fix visualize app - new charts library visualize area charts date histogram when no time filter interval errors should show error when calendar interval invalid #196308

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7ab56c
catch
Dosant Oct 15, 2024
3ddba7e
Merge branch 'main' into react18/viz-editor-error
elasticmachine Oct 17, 2024
9bbb3b7
Merge branch 'main' into react18/viz-editor-error
elasticmachine Oct 18, 2024
b00ec02
Merge branch 'main' into react18/viz-editor-error
elasticmachine Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/plugins/data/common/search/aggs/buckets/date_histogram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,14 @@ export const getDateHistogramBucketAgg = ({
dateFormat: getConfig('dateFormat'),
'dateFormat:scaled': getConfig('dateFormat:scaled'),
});
updateTimeBuckets(this, calculateBounds, buckets);

try {
updateTimeBuckets(this, calculateBounds, buckets);
} catch (e) {
// swallow the error even though the agg is misconfigured
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe and shouldn't break anything because this is inside the accessor and previosly threw error only on a first attempt to access. Now at least it would be consistent

// eslint-disable-next-line no-console
console.error(e);
}

return buckets;
},
Expand Down