Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution][Onboarding] Send Telemetry when integration tabs or cards clicked #196291

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Oct 15, 2024

Summary

#196145

To verify:

  1. Add these lines to kibana.dev.yml
logging.browser.root.level: debug
telemetry.optIn: true
  1. In the onboarding hub, expand the integration card.
    It should log onboarding_tab_${tabId} on tabs clicked.
Screen.Recording.2024-10-15.at.13.15.46.mov

It should log onboarding_card_${integrationId} on integration cards clicked.

Screen.Recording.2024-10-15.at.13.16.10.mov
  1. Manage integrations callout link clicked:: onboarding_manage_integrations;
  2. Endpoint callout link clicked: onboarding_endpoint_learn_more;
  3. Agentless callout link clicked: onboarding_agentless_learn_more;
  4. Agent still required callout link clicked: onboarding_agent_required;

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc changed the title track integration tabs and cards clicked [SecuritySolution][Onboarding] Send Telemetry when integration tabs or cards clicked Oct 15, 2024
@angorayc angorayc added the ci:cloud-deploy Create or update a Cloud deployment label Oct 16, 2024
@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc angorayc marked this pull request as ready for review October 17, 2024 15:28
@angorayc angorayc requested a review from a team as a code owner October 17, 2024 15:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@angorayc angorayc requested a review from a team October 18, 2024 11:00
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angorayc angorayc enabled auto-merge (squash) October 22, 2024 12:59
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 22, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #83 / discover/context_awareness extension getDocViewer data view mode should not render logs overview tab for non-logs data source

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6035 6036 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB +626.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 87.5KB 87.5KB +26.0B

History

@angorayc angorayc merged commit 2b27089 into elastic:main Oct 22, 2024
47 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 6.8, 7.17, 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11463898044

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 22, 2024
…r cards clicked (elastic#196291)

## Summary
elastic#196145

To verify:

1. Add these lines to `kibana.dev.yml`
```
logging.browser.root.level: debug
telemetry.optIn: true
```
2. In the onboarding hub, expand the integration card.
It should log `onboarding_tab_${tabId}` on tabs clicked.

https://github.com/user-attachments/assets/bd30c9ed-7c99-4ca0-93e7-6d9bf0146e62

It should log `onboarding_card_${integrationId}` on integration cards
clicked.

https://github.com/user-attachments/assets/58750d88-7bbf-4b27-8e54-587f3f6f32c2

3. Manage integrations callout link clicked::
`onboarding_manage_integrations`;
4. Endpoint callout link clicked: `onboarding_endpoint_learn_more`;
5. Agentless callout link clicked: `onboarding_agentless_learn_more`;
6. Agent still required callout link clicked:
`onboarding_agent_required`;

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 2b27089)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 22, 2024
…r cards clicked (elastic#196291)

## Summary
elastic#196145

To verify:

1. Add these lines to `kibana.dev.yml`
```
logging.browser.root.level: debug
telemetry.optIn: true
```
2. In the onboarding hub, expand the integration card.
It should log `onboarding_tab_${tabId}` on tabs clicked.

https://github.com/user-attachments/assets/bd30c9ed-7c99-4ca0-93e7-6d9bf0146e62

It should log `onboarding_card_${integrationId}` on integration cards
clicked.

https://github.com/user-attachments/assets/58750d88-7bbf-4b27-8e54-587f3f6f32c2

3. Manage integrations callout link clicked::
`onboarding_manage_integrations`;
4. Endpoint callout link clicked: `onboarding_endpoint_learn_more`;
5. Agentless callout link clicked: `onboarding_agentless_learn_more`;
6. Agent still required callout link clicked:
`onboarding_agent_required`;

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 2b27089)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
6.8 Backport failed because of merge conflicts
7.17 Backport failed because of merge conflicts
8.15 Backport failed because of merge conflicts
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 196291

Questions ?

Please refer to the Backport tool documentation

@angorayc angorayc removed the v6.8.16 label Oct 22, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 22, 2024
kibanamachine added a commit that referenced this pull request Oct 22, 2024
… tabs or cards clicked (#196291) (#197296)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[SecuritySolution][Onboarding] Send Telemetry when integration tabs
or cards clicked
(#196291)](#196291)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T15:52:43Z","message":"[SecuritySolution][Onboarding]
Send Telemetry when integration tabs or cards clicked (#196291)\n\n##
Summary\r\nhttps://github.com//issues/196145\r\n\r\nTo
verify:\r\n\r\n1. Add these lines to
`kibana.dev.yml`\r\n```\r\nlogging.browser.root.level:
debug\r\ntelemetry.optIn: true\r\n```\r\n2. In the onboarding hub,
expand the integration card.\r\nIt should log `onboarding_tab_${tabId}`
on tabs
clicked.\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bd30c9ed-7c99-4ca0-93e7-6d9bf0146e62\r\n\r\n\r\nIt
should log `onboarding_card_${integrationId}` on integration
cards\r\nclicked.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/58750d88-7bbf-4b27-8e54-587f3f6f32c2\r\n\r\n\r\n3.
Manage integrations callout link
clicked::\r\n`onboarding_manage_integrations`;\r\n4. Endpoint callout
link clicked: `onboarding_endpoint_learn_more`;\r\n5. Agentless callout
link clicked: `onboarding_agentless_learn_more`;\r\n6. Agent still
required callout link
clicked:\r\n`onboarding_agent_required`;\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2b270897a3f22ed5ca04ef173895cfa8660f9ea2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","v6.8.16","Team:Threat
Hunting:Explore","ci:cloud-deploy"],"title":"[SecuritySolution][Onboarding]
Send Telemetry when integration tabs or cards
clicked","number":196291,"url":"https://github.com/elastic/kibana/pull/196291","mergeCommit":{"message":"[SecuritySolution][Onboarding]
Send Telemetry when integration tabs or cards clicked (#196291)\n\n##
Summary\r\nhttps://github.com//issues/196145\r\n\r\nTo
verify:\r\n\r\n1. Add these lines to
`kibana.dev.yml`\r\n```\r\nlogging.browser.root.level:
debug\r\ntelemetry.optIn: true\r\n```\r\n2. In the onboarding hub,
expand the integration card.\r\nIt should log `onboarding_tab_${tabId}`
on tabs
clicked.\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bd30c9ed-7c99-4ca0-93e7-6d9bf0146e62\r\n\r\n\r\nIt
should log `onboarding_card_${integrationId}` on integration
cards\r\nclicked.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/58750d88-7bbf-4b27-8e54-587f3f6f32c2\r\n\r\n\r\n3.
Manage integrations callout link
clicked::\r\n`onboarding_manage_integrations`;\r\n4. Endpoint callout
link clicked: `onboarding_endpoint_learn_more`;\r\n5. Agentless callout
link clicked: `onboarding_agentless_learn_more`;\r\n6. Agent still
required callout link
clicked:\r\n`onboarding_agent_required`;\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2b270897a3f22ed5ca04ef173895cfa8660f9ea2"}},"sourceBranch":"main","suggestedTargetBranches":["6.8"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196291","number":196291,"mergeCommit":{"message":"[SecuritySolution][Onboarding]
Send Telemetry when integration tabs or cards clicked (#196291)\n\n##
Summary\r\nhttps://github.com//issues/196145\r\n\r\nTo
verify:\r\n\r\n1. Add these lines to
`kibana.dev.yml`\r\n```\r\nlogging.browser.root.level:
debug\r\ntelemetry.optIn: true\r\n```\r\n2. In the onboarding hub,
expand the integration card.\r\nIt should log `onboarding_tab_${tabId}`
on tabs
clicked.\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bd30c9ed-7c99-4ca0-93e7-6d9bf0146e62\r\n\r\n\r\nIt
should log `onboarding_card_${integrationId}` on integration
cards\r\nclicked.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/58750d88-7bbf-4b27-8e54-587f3f6f32c2\r\n\r\n\r\n3.
Manage integrations callout link
clicked::\r\n`onboarding_manage_integrations`;\r\n4. Endpoint callout
link clicked: `onboarding_endpoint_learn_more`;\r\n5. Agentless callout
link clicked: `onboarding_agentless_learn_more`;\r\n6. Agent still
required callout link
clicked:\r\n`onboarding_agent_required`;\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2b270897a3f22ed5ca04ef173895cfa8660f9ea2"}},{"branch":"6.8","label":"v6.8.16","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 23, 2024
…tabs or cards clicked (#196291) (#197297)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution][Onboarding] Send Telemetry when integration tabs
or cards clicked
(#196291)](#196291)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T15:52:43Z","message":"[SecuritySolution][Onboarding]
Send Telemetry when integration tabs or cards clicked (#196291)\n\n##
Summary\r\nhttps://github.com//issues/196145\r\n\r\nTo
verify:\r\n\r\n1. Add these lines to
`kibana.dev.yml`\r\n```\r\nlogging.browser.root.level:
debug\r\ntelemetry.optIn: true\r\n```\r\n2. In the onboarding hub,
expand the integration card.\r\nIt should log `onboarding_tab_${tabId}`
on tabs
clicked.\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bd30c9ed-7c99-4ca0-93e7-6d9bf0146e62\r\n\r\n\r\nIt
should log `onboarding_card_${integrationId}` on integration
cards\r\nclicked.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/58750d88-7bbf-4b27-8e54-587f3f6f32c2\r\n\r\n\r\n3.
Manage integrations callout link
clicked::\r\n`onboarding_manage_integrations`;\r\n4. Endpoint callout
link clicked: `onboarding_endpoint_learn_more`;\r\n5. Agentless callout
link clicked: `onboarding_agentless_learn_more`;\r\n6. Agent still
required callout link
clicked:\r\n`onboarding_agent_required`;\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2b270897a3f22ed5ca04ef173895cfa8660f9ea2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","v6.8.16","Team:Threat
Hunting:Explore","ci:cloud-deploy"],"title":"[SecuritySolution][Onboarding]
Send Telemetry when integration tabs or cards
clicked","number":196291,"url":"https://github.com/elastic/kibana/pull/196291","mergeCommit":{"message":"[SecuritySolution][Onboarding]
Send Telemetry when integration tabs or cards clicked (#196291)\n\n##
Summary\r\nhttps://github.com//issues/196145\r\n\r\nTo
verify:\r\n\r\n1. Add these lines to
`kibana.dev.yml`\r\n```\r\nlogging.browser.root.level:
debug\r\ntelemetry.optIn: true\r\n```\r\n2. In the onboarding hub,
expand the integration card.\r\nIt should log `onboarding_tab_${tabId}`
on tabs
clicked.\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bd30c9ed-7c99-4ca0-93e7-6d9bf0146e62\r\n\r\n\r\nIt
should log `onboarding_card_${integrationId}` on integration
cards\r\nclicked.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/58750d88-7bbf-4b27-8e54-587f3f6f32c2\r\n\r\n\r\n3.
Manage integrations callout link
clicked::\r\n`onboarding_manage_integrations`;\r\n4. Endpoint callout
link clicked: `onboarding_endpoint_learn_more`;\r\n5. Agentless callout
link clicked: `onboarding_agentless_learn_more`;\r\n6. Agent still
required callout link
clicked:\r\n`onboarding_agent_required`;\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2b270897a3f22ed5ca04ef173895cfa8660f9ea2"}},"sourceBranch":"main","suggestedTargetBranches":["6.8"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196291","number":196291,"mergeCommit":{"message":"[SecuritySolution][Onboarding]
Send Telemetry when integration tabs or cards clicked (#196291)\n\n##
Summary\r\nhttps://github.com//issues/196145\r\n\r\nTo
verify:\r\n\r\n1. Add these lines to
`kibana.dev.yml`\r\n```\r\nlogging.browser.root.level:
debug\r\ntelemetry.optIn: true\r\n```\r\n2. In the onboarding hub,
expand the integration card.\r\nIt should log `onboarding_tab_${tabId}`
on tabs
clicked.\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bd30c9ed-7c99-4ca0-93e7-6d9bf0146e62\r\n\r\n\r\nIt
should log `onboarding_card_${integrationId}` on integration
cards\r\nclicked.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/58750d88-7bbf-4b27-8e54-587f3f6f32c2\r\n\r\n\r\n3.
Manage integrations callout link
clicked::\r\n`onboarding_manage_integrations`;\r\n4. Endpoint callout
link clicked: `onboarding_endpoint_learn_more`;\r\n5. Agentless callout
link clicked: `onboarding_agentless_learn_more`;\r\n6. Agent still
required callout link
clicked:\r\n`onboarding_agent_required`;\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2b270897a3f22ed5ca04ef173895cfa8660f9ea2"}},{"branch":"6.8","label":"v6.8.16","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting backport ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants