[Lens][Expressions] Fixes react Error When Rendering Recoverable Error #196285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
mbondyra
added
backport:prev-minor
💚 Build Succeeded
Metrics [docs]Async chunks
|
markov00
approved these changes
Oct 17, 2024
| setIsRenderComplete(true); | ||
| onRender$(); | ||
| }, [setIsRenderComplete, onRender$]); | ||
| }, [onRender$, setDynamicError, setIsRenderComplete]); |
There was a problem hiding this comment.
qq: Could be great to know what a DynamicError is since it looks like used only in this workspace_panel file.
Why is "dynamic"?
There was a problem hiding this comment.
I guess what we meant the error is runtime and coming from the fact we cannot generate expression (so most likely it would be a wrong kql syntax or a user mistake that can be recoverable). When it appears, ExpressionRendererComponent instead of trying to render the expression, renders the content of the renderError prop.
What if we call it hasRequestError / setHasRequestError instead? 🤔
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
elastic#196285) ## Summary 1. Fixes elastic#159146 2. Makes sure that the `data-render-error` disappears once the expression renderer is recovered (ie. when user fixes the query) - before once the error appears, it stays there forever. <img width="651" alt="Screenshot 2024-10-15 at 13 11 14" src="https://github.com/user-attachments/assets/9fc3639a-723f-4ab2-9508-85caa4052ab9"> (cherry picked from commit 8cfa396)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
…e Error (#196285) (#196714) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Expressions] Fixes react Error When Rendering Recoverable Error (#196285)](#196285) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T14:22:01Z","message":"[Lens][Expressions] Fixes react Error When Rendering Recoverable Error (#196285)\n\n## Summary\r\n\r\n1. Fixes https://github.com/elastic/kibana/issues/159146\r\n2. Makes sure that the `data-render-error` disappears once the\r\nexpression renderer is recovered (ie. when user fixes the query) -\r\nbefore once the error appears, it stays there forever.\r\n\r\n\r\n<img width=\"651\" alt=\"Screenshot 2024-10-15 at 13 11 14\"\r\nsrc=\"https://github.com/user-attachments/assets/9fc3639a-723f-4ab2-9508-85caa4052ab9\">","sha":"8cfa396f463b10006f247f91c10c591ac19f6dc2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v9.0.0","backport:prev-minor","v8.17.0"],"title":"[Lens][Expressions] Fixes react Error When Rendering Recoverable Error","number":196285,"url":"https://github.com/elastic/kibana/pull/196285","mergeCommit":{"message":"[Lens][Expressions] Fixes react Error When Rendering Recoverable Error (#196285)\n\n## Summary\r\n\r\n1. Fixes https://github.com/elastic/kibana/issues/159146\r\n2. Makes sure that the `data-render-error` disappears once the\r\nexpression renderer is recovered (ie. when user fixes the query) -\r\nbefore once the error appears, it stays there forever.\r\n\r\n\r\n<img width=\"651\" alt=\"Screenshot 2024-10-15 at 13 11 14\"\r\nsrc=\"https://github.com/user-attachments/assets/9fc3639a-723f-4ab2-9508-85caa4052ab9\">","sha":"8cfa396f463b10006f247f91c10c591ac19f6dc2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196285","number":196285,"mergeCommit":{"message":"[Lens][Expressions] Fixes react Error When Rendering Recoverable Error (#196285)\n\n## Summary\r\n\r\n1. Fixes https://github.com/elastic/kibana/issues/159146\r\n2. Makes sure that the `data-render-error` disappears once the\r\nexpression renderer is recovered (ie. when user fixes the query) -\r\nbefore once the error appears, it stays there forever.\r\n\r\n\r\n<img width=\"651\" alt=\"Screenshot 2024-10-15 at 13 11 14\"\r\nsrc=\"https://github.com/user-attachments/assets/9fc3639a-723f-4ab2-9508-85caa4052ab9\">","sha":"8cfa396f463b10006f247f91c10c591ac19f6dc2"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
data-render-errordisappears once the expression renderer is recovered (ie. when user fixes the query) - before once the error appears, it stays there forever.