Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade request-converter for 8.16 #196193

Merged
merged 3 commits into from
Oct 16, 2024
Merged

upgrade request-converter for 8.16 #196193

merged 3 commits into from
Oct 16, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 14, 2024 •
edited by kibanamachine
Loading

Summary

https://github.com/elastic/request-converter needs to be updated regularly to maintain support for the latest ES apis.

@mattkime
Copy link
Contributor Author

/ci

@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime self-assigned this Oct 15, 2024
@mattkime mattkime added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 15, 2024
@mattkime mattkime requested a review from ElenaStoeva October 15, 2024 23:09
@mattkime mattkime marked this pull request as ready for review October 15, 2024 23:09
@mattkime mattkime changed the title upgrade request-converter upgrade request-converter for 8.16 Oct 15, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / discover/group2/data_grid1 discover data grid context tests should open the context view with the selected document as anchor
  • [job] [logs] FTR Configs #46 / endpoint Endpoint Exceptions should add event.module=endpoint to entry if only wildcard operator is present
  • [job] [logs] FTR Configs #68 / endpoint Endpoint Exceptions should add event.module=endpoint to entry if only wildcard operator is present

Metrics [docs]

✅ unchanged

History

cc @mattkime

@mattkime mattkime enabled auto-merge (squash) October 16, 2024 00:57
ElenaStoeva
ElenaStoeva approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the request-converter @mattkime! Tested the "Copy as" functionality in Console to make sure it still works as expected, changes also lgtm.

@mattkime mattkime merged commit d3fc354 into elastic:main Oct 16, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11364054650

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 16, 2024
@mattkime
upgrade request-converter for 8.16 (elastic#196193)
3447e16 
## Summary

https://github.com/elastic/request-converter needs to be updated
regularly to maintain support for the latest ES apis.

(cherry picked from commit d3fc354)
@kibanamachine kibanamachine mentioned this pull request Oct 16, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 16, 2024
@kibanamachine @mattkime
[8.x] upgrade request-converter for 8.16 (#196193) (#196530)
086d02d 
# Backport

This will backport the following commits from `main` to `8.x`:
- [upgrade request-converter for 8.16
(#196193)](#196193)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T10:44:34Z","message":"upgrade
request-converter for 8.16 (#196193)\n\n##
Summary\r\n\r\nhttps://github.com/elastic/request-converter needs to be
updated\r\nregularly to maintain support for the latest ES
apis.","sha":"d3fc354cbbd1985e7da95cbed132e05af856b740","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"upgrade
request-converter for
8.16","number":196193,"url":"https://github.com/elastic/kibana/pull/196193","mergeCommit":{"message":"upgrade
request-converter for 8.16 (#196193)\n\n##
Summary\r\n\r\nhttps://github.com/elastic/request-converter needs to be
updated\r\nregularly to maintain support for the latest ES
apis.","sha":"d3fc354cbbd1985e7da95cbed132e05af856b740"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196193","number":196193,"mergeCommit":{"message":"upgrade
request-converter for 8.16 (#196193)\n\n##
Summary\r\n\r\nhttps://github.com/elastic/request-converter needs to be
updated\r\nregularly to maintain support for the latest ES
apis.","sha":"d3fc354cbbd1985e7da95cbed132e05af856b740"}}]}] BACKPORT-->

Co-authored-by: Matthew Kime <[email protected]>
@mattkime mattkime mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

Assignees

@mattkime mattkime

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattkime @elasticmachine @kibanamachine @ElenaStoeva