[Entity Analytics] Allow task status to be "claiming" in disable/enable test #196172
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @hop-dev |
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
…le test (elastic#196172) ## Summary Closes elastic#196166 The test is checking that when we disable the risk engine, the risk ewngine task is registered but not actively running. This check originally checked if the task status was "idle". We have had a failure where the task status is "claiming", reading the docs about this task status (below) this is also an acceptable "non-running" status ``` // idle: Task Instance isn't being worked on // claiming: A Kibana instance has claimed ownership but hasn't started running // the Task Instance yet ``` (cherry picked from commit 40bfd12)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
… in disable/enable test (#196172) (#196454) # Backport This will backport the following commits from `main` to `8.x`: - [[Entity Analytics] Allow task status to be "claiming" in disable/enable test (#196172)](#196172) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T22:27:50Z","message":"[Entity Analytics] Allow task status to be \"claiming\" in disable/enable test (#196172)\n\n## Summary\r\n\r\nCloses #196166 \r\n\r\nThe test is checking that when we disable the risk engine, the risk\r\newngine task is registered but not actively running.\r\n\r\nThis check originally checked if the task status was \"idle\".\r\n\r\nWe have had a failure where the task status is \"claiming\", reading the\r\ndocs about this task status (below) this is also an acceptable\r\n\"non-running\" status\r\n\r\n```\r\n // idle: Task Instance isn't being worked on\r\n // claiming: A Kibana instance has claimed ownership but hasn't started running\r\n // the Task Instance yet\r\n```","sha":"40bfd12cc55ebfb1641ef21133fb009c23b0106f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Entity Analytics"],"title":"[Entity Analytics] Allow task status to be \"claiming\" in disable/enable test","number":196172,"url":"https://github.com/elastic/kibana/pull/196172","mergeCommit":{"message":"[Entity Analytics] Allow task status to be \"claiming\" in disable/enable test (#196172)\n\n## Summary\r\n\r\nCloses #196166 \r\n\r\nThe test is checking that when we disable the risk engine, the risk\r\newngine task is registered but not actively running.\r\n\r\nThis check originally checked if the task status was \"idle\".\r\n\r\nWe have had a failure where the task status is \"claiming\", reading the\r\ndocs about this task status (below) this is also an acceptable\r\n\"non-running\" status\r\n\r\n```\r\n // idle: Task Instance isn't being worked on\r\n // claiming: A Kibana instance has claimed ownership but hasn't started running\r\n // the Task Instance yet\r\n```","sha":"40bfd12cc55ebfb1641ef21133fb009c23b0106f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196172","number":196172,"mergeCommit":{"message":"[Entity Analytics] Allow task status to be \"claiming\" in disable/enable test (#196172)\n\n## Summary\r\n\r\nCloses #196166 \r\n\r\nThe test is checking that when we disable the risk engine, the risk\r\newngine task is registered but not actively running.\r\n\r\nThis check originally checked if the task status was \"idle\".\r\n\r\nWe have had a failure where the task status is \"claiming\", reading the\r\ndocs about this task status (below) this is also an acceptable\r\n\"non-running\" status\r\n\r\n```\r\n // idle: Task Instance isn't being worked on\r\n // claiming: A Kibana instance has claimed ownership but hasn't started running\r\n // the Task Instance yet\r\n```","sha":"40bfd12cc55ebfb1641ef21133fb009c23b0106f"}}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #196166
The test is checking that when we disable the risk engine, the risk ewngine task is registered but not actively running.
This check originally checked if the task status was "idle".
We have had a failure where the task status is "claiming", reading the docs about this task status (below) this is also an acceptable "non-running" status