fix: updating dashboard - initial save button state is "disabled" #196137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulinashakirova
added
the
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
packages/content-management/content_editor/src/components/inspector_flyout_content.test.tsx
Show resolved
Hide resolved
paulinashakirova
added
backport:prev-minor
Dosant
reviewed
Oct 16, 2024
packages/content-management/content_editor/src/components/editor_flyout_content.tsx
Show resolved
Hide resolved
paulinashakirova
force-pushed
the
update-dashboard-intial-save-button-disabled
branch
from
e08a3f6 to
906af8a
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
…astic#196137) ## Summary This PR fixes [[Dashboard] User can click on update dashboard even without changing anything](elastic#187800) issue. ## Change - When the flyout is open, the initial state of the button is `disabled`. - When there is a change made, the `disabled` state is removed.   (cherry picked from commit 0ead257)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
paulinashakirova
deleted the
update-dashboard-intial-save-button-disabled
branch
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
…sabled" (#196137) (#196661) # Backport This will backport the following commits from `main` to `8.x`: - [fix: updating dashboard - initial save button state is "disabled" (#196137)](#196137) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T10:39:42Z","message":"fix: updating dashboard - initial save button state is \"disabled\" (#196137)\n\n## Summary\r\n\r\nThis PR fixes [[Dashboard] User can click on update dashboard even\r\nwithout changing\r\nanything](#187800) issue.\r\n\r\n## Change\r\n\r\n- When the flyout is open, the initial state of the button is\r\n`disabled`.\r\n- When there is a change made, the `disabled` state is removed.\r\n\r\n\r\n\r\n","sha":"0ead257ff4912218775a70484ac5754b4b3baa31","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"fix: updating dashboard - initial save button state is \"disabled\"","number":196137,"url":"https://github.com/elastic/kibana/pull/196137","mergeCommit":{"message":"fix: updating dashboard - initial save button state is \"disabled\" (#196137)\n\n## Summary\r\n\r\nThis PR fixes [[Dashboard] User can click on update dashboard even\r\nwithout changing\r\nanything](#187800) issue.\r\n\r\n## Change\r\n\r\n- When the flyout is open, the initial state of the button is\r\n`disabled`.\r\n- When there is a change made, the `disabled` state is removed.\r\n\r\n\r\n\r\n","sha":"0ead257ff4912218775a70484ac5754b4b3baa31"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196137","number":196137,"mergeCommit":{"message":"fix: updating dashboard - initial save button state is \"disabled\" (#196137)\n\n## Summary\r\n\r\nThis PR fixes [[Dashboard] User can click on update dashboard even\r\nwithout changing\r\nanything](#187800) issue.\r\n\r\n## Change\r\n\r\n- When the flyout is open, the initial state of the button is\r\n`disabled`.\r\n- When there is a change made, the `disabled` state is removed.\r\n\r\n\r\n\r\n","sha":"0ead257ff4912218775a70484ac5754b4b3baa31"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes [Dashboard] User can click on update dashboard even without changing anything issue.
Change
disabled.disabledstate is removed.