-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset Quality] Fix failing test on mki qa #196122
Merged
achyutjhunjhunwala
merged 38 commits into
elastic:main
from
achyutjhunjhunwala:fix-failing-test-on-mki-qa
Oct 14, 2024
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
b34b9f1
Fix refresh table breaking for summary
achyutjhunjhunwala d1fdaeb
Add timeout to find
achyutjhunjhunwala ac496c4
Merge branch 'elastic:main' into main
achyutjhunjhunwala 12cad21
Merge branch 'elastic:main' into main
achyutjhunjhunwala db7d63b
Revert "Add timeout to find"
achyutjhunjhunwala c3a2774
Revert "Fix refresh table breaking for summary"
achyutjhunjhunwala 9ba8128
Merge branch 'elastic:main' into main
achyutjhunjhunwala 425cdb4
Merge branch 'elastic:main' into main
achyutjhunjhunwala a5ccc32
Merge branch 'elastic:main' into main
achyutjhunjhunwala 1ab7806
Merge branch 'elastic:main' into main
achyutjhunjhunwala abad280
Merge branch 'elastic:main' into main
achyutjhunjhunwala 14a3620
Merge branch 'elastic:main' into main
achyutjhunjhunwala 0dd0eb1
Merge branch 'elastic:main' into main
achyutjhunjhunwala 2dd64cc
Merge branch 'elastic:main' into main
achyutjhunjhunwala 3833283
Merge branch 'elastic:main' into main
achyutjhunjhunwala a1a1ce1
Merge branch 'elastic:main' into main
achyutjhunjhunwala 6278a51
Merge branch 'elastic:main' into main
achyutjhunjhunwala 14161a3
Merge branch 'elastic:main' into main
achyutjhunjhunwala 2df6d10
Merge branch 'elastic:main' into main
achyutjhunjhunwala 99d8084
Merge branch 'elastic:main' into main
achyutjhunjhunwala 28e789c
Merge branch 'elastic:main' into main
achyutjhunjhunwala 59fc802
Merge branch 'elastic:main' into main
achyutjhunjhunwala dec1cae
Merge branch 'elastic:main' into main
achyutjhunjhunwala 33c0c60
Merge branch 'elastic:main' into main
achyutjhunjhunwala 6f5c1c6
Merge branch 'elastic:main' into main
achyutjhunjhunwala fbf7d08
Merge branch 'elastic:main' into main
achyutjhunjhunwala 55d1cff
Merge branch 'elastic:main' into main
achyutjhunjhunwala 73ae28d
Merge branch 'elastic:main' into main
achyutjhunjhunwala b475502
Merge branch 'elastic:main' into main
achyutjhunjhunwala 53e9a19
Merge branch 'elastic:main' into main
achyutjhunjhunwala ddb587a
Merge branch 'elastic:main' into main
achyutjhunjhunwala a3cb5cc
Merge branch 'elastic:main' into main
achyutjhunjhunwala 60ebd22
Fix mapping issue with logs db on mki
achyutjhunjhunwala 07412cc
Fix mapping issue with logs db on mki for FTR tests
achyutjhunjhunwala b35cc0b
Fix mapping issue with logs db on mki for FTR tests for stateful
achyutjhunjhunwala 74d6a6b
Merge branch 'main' into fix-failing-test-on-mki-qa
achyutjhunjhunwala 68889cb
Remove skip on MKI tag
achyutjhunjhunwala 42b8347
Merge branch 'main' into fix-failing-test-on-mki-qa
achyutjhunjhunwala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
...ment_agnostic/apis/observability/dataset_quality/custom_mappings/custom_synth_mappings.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { MappingTypeMapping } from '@elastic/elasticsearch/lib/api/types'; | ||
|
||
export const logsSynthMappings = (dataset: string): MappingTypeMapping => ({ | ||
properties: { | ||
'@timestamp': { | ||
type: 'date', | ||
ignore_malformed: false, | ||
}, | ||
data_stream: { | ||
properties: { | ||
dataset: { | ||
type: 'constant_keyword', | ||
value: dataset, | ||
}, | ||
namespace: { | ||
type: 'constant_keyword', | ||
value: 'default', | ||
}, | ||
type: { | ||
type: 'constant_keyword', | ||
value: 'logs', | ||
}, | ||
}, | ||
}, | ||
event: { | ||
properties: { | ||
dataset: { | ||
type: 'keyword', | ||
ignore_above: 1024, | ||
}, | ||
}, | ||
}, | ||
host: { | ||
properties: { | ||
name: { | ||
type: 'keyword', | ||
fields: { | ||
text: { | ||
type: 'match_only_text', | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
input: { | ||
properties: { | ||
type: { | ||
type: 'keyword', | ||
ignore_above: 1024, | ||
}, | ||
}, | ||
}, | ||
log: { | ||
properties: { | ||
file: { | ||
properties: { | ||
path: { | ||
type: 'keyword', | ||
fields: { | ||
text: { | ||
type: 'match_only_text', | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
message: { | ||
type: 'match_only_text', | ||
}, | ||
network: { | ||
properties: { | ||
bytes: { | ||
type: 'long', | ||
}, | ||
}, | ||
}, | ||
service: { | ||
properties: { | ||
name: { | ||
type: 'keyword', | ||
fields: { | ||
text: { | ||
type: 'match_only_text', | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
test_field: { | ||
type: 'keyword', | ||
ignore_above: 1024, | ||
}, | ||
tls: { | ||
properties: { | ||
established: { | ||
type: 'boolean', | ||
}, | ||
}, | ||
}, | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
x-pack/test/functional/apps/dataset_quality/custom_mappings/custom_synth_mappings.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { MappingTypeMapping } from '@elastic/elasticsearch/lib/api/types'; | ||
|
||
export const logsSynthMappings = (dataset: string): MappingTypeMapping => ({ | ||
properties: { | ||
'@timestamp': { | ||
type: 'date', | ||
ignore_malformed: false, | ||
}, | ||
data_stream: { | ||
properties: { | ||
dataset: { | ||
type: 'constant_keyword', | ||
value: 'degraded.dataset.rca', | ||
}, | ||
namespace: { | ||
type: 'constant_keyword', | ||
value: 'default', | ||
}, | ||
type: { | ||
type: 'constant_keyword', | ||
value: 'logs', | ||
}, | ||
}, | ||
}, | ||
event: { | ||
properties: { | ||
dataset: { | ||
type: 'keyword', | ||
ignore_above: 1024, | ||
}, | ||
}, | ||
}, | ||
host: { | ||
properties: { | ||
name: { | ||
type: 'keyword', | ||
fields: { | ||
text: { | ||
type: 'match_only_text', | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
input: { | ||
properties: { | ||
type: { | ||
type: 'keyword', | ||
ignore_above: 1024, | ||
}, | ||
}, | ||
}, | ||
log: { | ||
properties: { | ||
level: { | ||
type: 'keyword', | ||
ignore_above: 1024, | ||
}, | ||
}, | ||
}, | ||
message: { | ||
type: 'match_only_text', | ||
}, | ||
network: { | ||
properties: { | ||
bytes: { | ||
type: 'long', | ||
}, | ||
}, | ||
}, | ||
service: { | ||
properties: { | ||
name: { | ||
type: 'keyword', | ||
fields: { | ||
text: { | ||
type: 'match_only_text', | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
test_field: { | ||
type: 'keyword', | ||
ignore_above: 1024, | ||
}, | ||
tls: { | ||
properties: { | ||
established: { | ||
type: 'boolean', | ||
}, | ||
}, | ||
}, | ||
trace: { | ||
properties: { | ||
id: { | ||
type: 'keyword', | ||
ignore_above: 1024, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to continue with test run when component template does not exist/failed to create?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well The only use case, where they will fail to create, would be either a Network issue or User roles and right issue. In that case, the test would fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is required by test to exist, I suggest throwing an error instead of just logging it. Thoughts?