[Cloud Posture] Adding CSP 3P support callout for Wiz integration #196025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanSh
added
release_note:skip
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Historycc @JordanSh |
…osture-fleet-wiz-callout
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
maxcold
reviewed
Oct 14, 2024
| const LS_CLOUD_POSTURE_3P_SUPPORT_WIZ_INTEGRATIONS_CALLOUT_KEY = | ||
| 'fleet:cloudSecurityPosture:thirdPartySupport:wizIntegrationsCallout'; | ||
|
|
||
| const CloudPostureThirdPartySupportCallout = () => { |
There was a problem hiding this comment.
What about having this component in its own file so we can add it to our team ownership? I would also pass the package name to it so that all the logic was inside the component, again to eliminate the risk smth being changed outside our our ownership. Ofc there always be the risk that the call of the component is deleted
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Oct 14, 2024
maxcold
approved these changes
Oct 14, 2024
|
Starting backport for target branches: 8.x |
JordanSh
removed
the
backport:prev-minor
JordanSh
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
JordanSh
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
JordanSh
removed
the
backport:prev-minor
JordanSh
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Oct 15, 2024
JordanSh
removed
the
backport:prev-minor
JordanSh
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
JordanSh
added a commit
to JordanSh/kibana
that referenced
this pull request
Oct 15, 2024
…astic#196025) (cherry picked from commit ebe16fa)
JordanSh
added a commit
that referenced
this pull request
Oct 15, 2024
…on (#196025) (#196274) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Posture] Adding CSP 3P support callout for Wiz integration (#196025)](#196025) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jordan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T12:35:25Z","message":"[Cloud Posture] Adding CSP 3P support callout for Wiz integration (#196025)","sha":"ebe16fa467d6e35e2398ad724780db05c27779cf","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud Security","backport:prev-minor"],"number":196025,"url":"https://github.com/elastic/kibana/pull/196025","mergeCommit":{"message":"[Cloud Posture] Adding CSP 3P support callout for Wiz integration (#196025)","sha":"ebe16fa467d6e35e2398ad724780db05c27779cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196025","number":196025,"mergeCommit":{"message":"[Cloud Posture] Adding CSP 3P support callout for Wiz integration (#196025)","sha":"ebe16fa467d6e35e2398ad724780db05c27779cf"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #187230
Callout will only be displayed on Wiz integration and on the condition that the user has not dismissed the callout already
Screen.Recording.2024-10-13.at.15.33.34.mov