Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search][Onboarding] Auto-collapse side on Global Empty State #195978

Closed
wants to merge 2 commits into from
Closed

[Search][Onboarding] Auto-collapse side on Global Empty State #195978

wants to merge 2 commits into from
+63 −0

Conversation

TattdCodeMonkey
Copy link
Contributor

Summary

Updates the global empty state to auto-collapse the side nav. This will happen if the global empty state is rendered with 0 indices on the start page.

Screenshots

image

Checklist

@TattdCodeMonkey
onboarding: collapse side nav on start page
da8f543 
Added a hook that will auto-collapse the side nav when loading the
global empty state. This is intended to give a focused view for first
time users.
@TattdCodeMonkey
test: auto-collapse side nav in global empty state
ac2e5bb
@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Search backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 11, 2024
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner October 11, 2024 18:59
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 11, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / AllCasesSelectorModal Closing modal when pressing the x icon
  • [job] [logs] Jest Tests #8 / Description it renders
  • [job] [logs] FTR Configs #41 / serverless search UI - feature flags Elasticsearch Start [Onboarding Empty State] developer should redirect to indices list if single index exist on page load
  • [job] [logs] FTR Configs #41 / serverless search UI - feature flags Elasticsearch Start [Onboarding Empty State] developer should redirect to indices list if single index exist on page load
  • [job] [logs] FTR Configs #11 / serverless search UI With custom role should have limited navigation menu
  • [job] [logs] FTR Configs #11 / serverless search UI With custom role should have limited navigation menu

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchIndices 221 222 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchIndices 156.7KB 157.0KB +253.0B

History

@TattdCodeMonkey TattdCodeMonkey deleted the onboarding/collapse-side-nav branch October 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TattdCodeMonkey @elasticmachine