[Entity Store] Do not require full entity definition to execute enrich policy (remove magic number) #195961
+23
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
hop-dev
commented
Oct 11, 2024
| const unitedDefinition = getUnitedEntityDefinition({ | ||
| namespace, | ||
| entityType, | ||
| fieldHistoryLength: 10, // we are not using this value so it can be anything |
There was a problem hiding this comment.
getting rid of this magic number is the motivation of the changes
hop-dev
changed the title
💚 Build Succeeded
Metrics [docs]
cc @hop-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@machadoum pointed out some weirdness in the task code where we have to provide the fieldHistoryLength, I have changed the executeEnrichPolicy method signature to only require the 3 fields it needs, one of those fields is the entity definition version, I have added a method to just get the version of an entity defintion so the task can provide it.