Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onboarding] fix skipped api key tests #195911

Merged
merged 10 commits into from
Oct 16, 2024
Merged

[Onboarding] fix skipped api key tests #195911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
467c965
fix api key tests
joemcelroy Oct 11, 2024
76586d4
Merge remote-tracking branch 'upstream/main' into fix-ftr-api-key-tests
joemcelroy Oct 11, 2024
de2f50f
update with beforeeach
joemcelroy Oct 11, 2024
f85bbe2
Merge branch 'main' into fix-ftr-api-key-tests
elasticmachine Oct 13, 2024
3e42b6b
Merge remote-tracking branch 'upstream/main' into fix-ftr-api-key-tests
joemcelroy Oct 14, 2024
32dd3e1
update ftrs
joemcelroy Oct 15, 2024
ba833c1
Merge branch 'main' into fix-ftr-api-key-tests
joemcelroy Oct 15, 2024
c091aeb
delete api keys before test
joemcelroy Oct 16, 2024
e1c2ea0
Merge remote-tracking branch 'upstream/main' into fix-ftr-api-key-tests
joemcelroy Oct 16, 2024
8cb68ac
Merge branch 'main' into fix-ftr-api-key-tests
elasticmachine Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions x-pack/test_serverless/functional/test_suites/search/elasticsearch_start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
describe('developer', function () {
before(async () => {
await pageObjects.svlCommonPage.loginWithRole('developer');
await pageObjects.svlApiKeys.deleteAPIKeys();
});
after(async () => {
await deleteAllTestIndices();
});
beforeEach(async () => {
await deleteAllTestIndices();
await pageObjects.svlApiKeys.deleteAPIKeys();
await svlSearchNavigation.navigateToElasticsearchStartPage();
});

Expand Down Expand Up @@ -92,8 +92,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await pageObjects.svlSearchElasticsearchStartPage.expectCreateIndexUIView();
});

// Failing: See https://github.com/elastic/kibana/issues/194673
it.skip('should show the api key in code view', async () => {
it('should show the api key in code view', async () => {
await pageObjects.svlSearchElasticsearchStartPage.expectToBeOnStartPage();
await pageObjects.svlSearchElasticsearchStartPage.clickCodeViewButton();
await pageObjects.svlApiKeys.expectAPIKeyAvailable();
Expand Down Expand Up @@ -131,8 +130,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await pageObjects.svlApiKeys.expectAPIKeyAvailable();
});

// Failing: See https://github.com/elastic/kibana/issues/194673
it.skip('Same API Key should be present on start page and index detail view', async () => {
it('Same API Key should be present on start page and index detail view', async () => {
await pageObjects.svlSearchElasticsearchStartPage.clickCodeViewButton();
await pageObjects.svlApiKeys.expectAPIKeyAvailable();
const apiKeyUI = await pageObjects.svlApiKeys.getAPIKeyFromUI();
Expand Down
15 changes: 8 additions & 7 deletions x-pack/test_serverless/functional/test_suites/search/search_index_detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await pageObjects.svlSearchIndexDetailPage.expectConnectionDetails();
});

it('should show api key', async () => {
await pageObjects.svlApiKeys.deleteAPIKeys();
await svlSearchNavigation.navigateToIndexDetailPage(indexName);
await pageObjects.svlApiKeys.expectAPIKeyAvailable();
const apiKey = await pageObjects.svlApiKeys.getAPIKeyFromUI();
await pageObjects.svlSearchIndexDetailPage.expectAPIKeyToBeVisibleInCodeBlock(apiKey);
});

it('should have quick stats', async () => {
await pageObjects.svlSearchIndexDetailPage.expectQuickStats();
await pageObjects.svlSearchIndexDetailPage.expectQuickStatsAIMappings();
Expand Down Expand Up @@ -89,13 +97,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await pageObjects.embeddedConsole.clickEmbeddedConsoleControlBar();
});

// Failing: See https://github.com/elastic/kibana/issues/194673
it.skip('should show api key', async () => {
await pageObjects.svlApiKeys.expectAPIKeyAvailable();
const apiKey = await pageObjects.svlApiKeys.getAPIKeyFromUI();
await pageObjects.svlSearchIndexDetailPage.expectAPIKeyToBeVisibleInCodeBlock(apiKey);
});

describe('With data', () => {
before(async () => {
await es.index({
Expand Down