[Security Assistant] Fix ESQL tool availability #195827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
peluja1012
reviewed
Oct 10, 2024
x-pack/plugins/security_solution/server/assistant/tools/esql/nl_to_esql_tool.test.ts
Outdated
Show resolved
Hide resolved
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
(cherry picked from commit 2b995fa)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Fix ESQL tool availability (#195827)](#195827) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T22:49:22Z","message":"[Security Assistant] Fix ESQL tool availability (#195827)","sha":"2b995fa86eb44a2bd54c44a74eb47a2a26ec0ed2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version"],"title":"[Security Assistant] Fix ESQL tool availability","number":195827,"url":"https://github.com/elastic/kibana/pull/195827","mergeCommit":{"message":"[Security Assistant] Fix ESQL tool availability (#195827)","sha":"2b995fa86eb44a2bd54c44a74eb47a2a26ec0ed2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195827","number":195827,"mergeCommit":{"message":"[Security Assistant] Fix ESQL tool availability (#195827)","sha":"2b995fa86eb44a2bd54c44a74eb47a2a26ec0ed2"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, Knowledge Base needed to be installed to use the ESQL tool. The NL to ESQL tool does not require Knowledge Base, so I removed this condition.
Additionally, I found that the chain input property
modelExistsis equal toisEnabledKnowledgeBase. EverywheremodelExistsis checked also checksisEnabledKnowledgeBase. Therefore, the condition is unnecessary and adds confusion. I removed it.Testing
To reproduce bug on main, start a fresh es + kibana (no elser/kb installed) and ask an ESQL question. Check your LangSmith trace to find the
NaturalLanguageESQLTooltool was not provided. Check out this branch and ask another ESQL question. Check your LangSmith trace once more to find theNaturalLanguageESQLTooltool was provided.