-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] [Bug] Setting the agentless policy inactivity_timeout to 1 hour so they don't show in the Fleet Agents list in Kibana #195808
Merged
seanrathier
merged 3 commits into
elastic:main
from
seanrathier:10453-bug-remove-old-offline-agentless-version2
Oct 12, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanrathier
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
Team:Cloud Security
Cloud Security team related
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
ci:cloud-deploy
Create or update a Cloud deployment
8.16 candidate
labels
Oct 10, 2024
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
seanrathier
changed the title
[Cloud Security] [Bug]Setting the agentless policy inactivity_timeout to 1 hour so they don't show in the Fleet Agents list in Kibana
[Cloud Security] [Bug] Setting the agentless policy inactivity_timeout to 1 hour so they don't show in the Fleet Agents list in Kibana
Oct 10, 2024
1 task
maxcold
approved these changes
Oct 11, 2024
jen-huang
approved these changes
Oct 11, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @seanrathier |
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 12, 2024
…t to 1 hour so they don't show in the Fleet Agents list in Kibana (elastic#195808) (cherry picked from commit 808c96b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 12, 2024
…timeout to 1 hour so they don't show in the Fleet Agents list in Kibana (#195808) (#196018) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] [Bug] Setting the agentless policy inactivity_timeout to 1 hour so they don't show in the Fleet Agents list in Kibana (#195808)](#195808) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-12T17:43:46Z","message":"[Cloud Security] [Bug] Setting the agentless policy inactivity_timeout to 1 hour so they don't show in the Fleet Agents list in Kibana (#195808)","sha":"808c96b749033810f70e23ee06ac0cba6219c4e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud Security","backport:prev-minor","ci:cloud-deploy","8.16 candidate"],"title":"[Cloud Security] [Bug] Setting the agentless policy inactivity_timeout to 1 hour so they don't show in the Fleet Agents list in Kibana","number":195808,"url":"https://github.com/elastic/kibana/pull/195808","mergeCommit":{"message":"[Cloud Security] [Bug] Setting the agentless policy inactivity_timeout to 1 hour so they don't show in the Fleet Agents list in Kibana (#195808)","sha":"808c96b749033810f70e23ee06ac0cba6219c4e7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195808","number":195808,"mergeCommit":{"message":"[Cloud Security] [Bug] Setting the agentless policy inactivity_timeout to 1 hour so they don't show in the Fleet Agents list in Kibana (#195808)","sha":"808c96b749033810f70e23ee06ac0cba6219c4e7"}}]}] BACKPORT--> Co-authored-by: seanrathier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.16 candidate
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
ci:cloud-deploy
Create or update a Cloud deployment
release_note:skip
Skip the PR/issue when compiling release notes
Team:Cloud Security
Cloud Security team related
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.16.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are filtering out of the Agents list in the Fleet UI for agentless agents that are offline more than 1 hour. We are doing this because the agentless agent might be restarted for various reasons such as updating the Elastic Agent version or updating the policy.
The agents are still online, however, the have a different ID, and the previous instance shows as offline.
closes https://github.com/elastic/security-team/issues/10453
Checklist