[Security Solution] Update footer link in rule preview to go to rule details page #195806
+25
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
christineweng
force-pushed
the
rule-footer-link
branch
from
4f7fca5 to
1aa3682
Compare
janmonschke
reviewed
Oct 10, 2024
x-pack/plugins/security_solution/public/flyout/rule_details/preview/footer.tsx
Outdated
Show resolved
Hide resolved
janmonschke
approved these changes
Oct 10, 2024
PhilippeOberti
approved these changes
Oct 10, 2024
…eview/footer.tsx Co-authored-by: Jan Monschke <[email protected]>
|
Starting backport for target branches: 8.15, 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
…details page (elastic#195806) ## Summary Currently, the rule preview footer will open the rule flyout. Although this behavior is consistent with other previews (host, user, alert etc.), the rule flyout does not provide additional information for users. This PR updates the footer go to rule details page instead. https://github.com/user-attachments/assets/6de03775-b1a4-41b9-b233-7817d6cca8ec ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Jan Monschke <[email protected]> (cherry picked from commit a397bb7)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
… rule details page (#195806) (#195833) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Update footer link in rule preview to go to rule details page (#195806)](#195806) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T21:59:54Z","message":"[Security Solution] Update footer link in rule preview to go to rule details page (#195806)\n\n## Summary\r\n\r\nCurrently, the rule preview footer will open the rule flyout. Although\r\nthis behavior is consistent with other previews (host, user, alert\r\netc.), the rule flyout does not provide additional information for\r\nusers. This PR updates the footer go to rule details page instead.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6de03775-b1a4-41b9-b233-7817d6cca8ec\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Jan Monschke <[email protected]>","sha":"a397bb72d52e865d0f44c6983bf01c85875251e8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","backport:prev-major","v8.16.0"],"title":"[Security Solution] Update footer link in rule preview to go to rule details page","number":195806,"url":"https://github.com/elastic/kibana/pull/195806","mergeCommit":{"message":"[Security Solution] Update footer link in rule preview to go to rule details page (#195806)\n\n## Summary\r\n\r\nCurrently, the rule preview footer will open the rule flyout. Although\r\nthis behavior is consistent with other previews (host, user, alert\r\netc.), the rule flyout does not provide additional information for\r\nusers. This PR updates the footer go to rule details page instead.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6de03775-b1a4-41b9-b233-7817d6cca8ec\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Jan Monschke <[email protected]>","sha":"a397bb72d52e865d0f44c6983bf01c85875251e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195806","number":195806,"mergeCommit":{"message":"[Security Solution] Update footer link in rule preview to go to rule details page (#195806)\n\n## Summary\r\n\r\nCurrently, the rule preview footer will open the rule flyout. Although\r\nthis behavior is consistent with other previews (host, user, alert\r\netc.), the rule flyout does not provide additional information for\r\nusers. This PR updates the footer go to rule details page instead.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6de03775-b1a4-41b9-b233-7817d6cca8ec\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Jan Monschke <[email protected]>","sha":"a397bb72d52e865d0f44c6983bf01c85875251e8"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
christineweng
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the rule preview footer will open the rule flyout. Although this behavior is consistent with other previews (host, user, alert etc.), the rule flyout does not provide additional information for users. This PR updates the footer go to rule details page instead.
Screen.Recording.2024-10-10.at.11.56.45.AM.mov
Checklist