Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Use test ID instead of closest button for flaky test #195791

Merged

Conversation

kpollich
Copy link
Member

Summary

Closes #191804

I haven't been able to reproduce any flakiness here, but this seems to be the only real difference between this test and those around it that don't have the same flakiness issue. So, I've updated the test to use a test ID like the non-flaky ones in the same suite.

@kpollich kpollich added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 10, 2024
@kpollich kpollich self-assigned this Oct 10, 2024
@kpollich kpollich requested a review from a team as a code owner October 10, 2024 14:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 10, 2024
@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kpollich kpollich enabled auto-merge (squash) October 10, 2024 15:07
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 10, 2024

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +44.0B

History

cc @kpollich

@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kpollich kpollich merged commit 273f02e into elastic:main Oct 11, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0
Projects
None yet
4 participants