Not allow # in index template name #195776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Index Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
sabarasaba
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Thanks for patching this up @SoniaSanzV! Code changes lgtm, tested locally.
I couldnt find any existing tests associated with this specific form validation, do you think is worth perhaps adding a simple one for doing that? 🤔 Perhaps is also a good oportunity to figure out what the process for adding tests looks like
Sure! I can do that! |
|
I've been working on the test for a couple of days but, after talking to @ElenaStoeva we agreed that a simple unit test that only adds a character to an existing functionality does not worth all this time. The problem is that when you add a value to the input using the testing library, the |
ElenaStoeva
approved these changes
Oct 15, 2024
|
/ci |
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
cc @SoniaSanzV |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
Closes [elastic#81870](elastic#81870) ## Summary When creating a new Template, it did not prevent entering a #, but when saving the template the user received an error. The hash has been added to the list of invalid characters for the name. https://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94 (cherry picked from commit 4339f84)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Not allow # in index template name (#195776)](#195776) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T07:16:36Z","message":"Not allow # in index template name (#195776)\n\nCloses [#81870](https://github.com/elastic/kibana/issues/81870)\r\n\r\n## Summary\r\n\r\nWhen creating a new Template, it did not prevent entering a #, but when\r\nsaving the template the user received an error. The hash has been added\r\nto the list of invalid characters for the name.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94","sha":"4339f8465720c507351a2e65a6fe881a10dcd938","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"Not allow # in index template name","number":195776,"url":"https://github.com/elastic/kibana/pull/195776","mergeCommit":{"message":"Not allow # in index template name (#195776)\n\nCloses [#81870](https://github.com/elastic/kibana/issues/81870)\r\n\r\n## Summary\r\n\r\nWhen creating a new Template, it did not prevent entering a #, but when\r\nsaving the template the user received an error. The hash has been added\r\nto the list of invalid characters for the name.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94","sha":"4339f8465720c507351a2e65a6fe881a10dcd938"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195776","number":195776,"mergeCommit":{"message":"Not allow # in index template name (#195776)\n\nCloses [#81870](https://github.com/elastic/kibana/issues/81870)\r\n\r\n## Summary\r\n\r\nWhen creating a new Template, it did not prevent entering a #, but when\r\nsaving the template the user received an error. The hash has been added\r\nto the list of invalid characters for the name.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94","sha":"4339f8465720c507351a2e65a6fe881a10dcd938"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81870
Summary
When creating a new Template, it did not prevent entering a #, but when saving the template the user received an error. The hash has been added to the list of invalid characters for the name.
81870.mov