[Dataset quality] Failure store support in synthtrace #195726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
yngrdyn
added
release_note:skip
packages/kbn-apm-synthtrace/src/lib/logs/logs_synthtrace_es_client.ts
Outdated
Show resolved
Hide resolved
packages/kbn-apm-synthtrace/src/lib/logs/logs_synthtrace_es_client.ts
Outdated
Show resolved
Hide resolved
packages/kbn-apm-synthtrace/src/lib/logs/logs_synthtrace_es_client.ts
Outdated
Show resolved
Hide resolved
MiriamAparicio
approved these changes
Oct 10, 2024
mohamedhamed-ahmed
approved these changes
Oct 10, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
History
cc @yngrdyn |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
This PR enables the creation of scenarios using failure store in synthtrace. #### How to test? 1. Run the scenario `node scripts/synthtrace failed_logs` 2. Go to dev console - For getting documents ingested `GET logs-*-*/_search`. This is equivalent to `GET logs-*-*/_search?failure_store=exclude` and will only include the documents that were properly ingested. - For getting documents in failure store `GET logs-*-*/_search?failure_store=only` https://github.com/user-attachments/assets/5013a0af-fdfc-453a-b70c-fb2c452ad4d8 (cherry picked from commit bf72e41)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…#195781) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset quality] Failure store support in synthtrace (#195726)](#195726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T14:19:52Z","message":"[Dataset quality] Failure store support in synthtrace (#195726)\n\nThis PR enables the creation of scenarios using failure store in\r\nsynthtrace.\r\n\r\n#### How to test?\r\n1. Run the scenario `node scripts/synthtrace failed_logs`\r\n2. Go to dev console\r\n- For getting documents ingested `GET logs-*-*/_search`. This is\r\nequivalent to `GET logs-*-*/_search?failure_store=exclude` and will only\r\ninclude the documents that were properly ingested.\r\n- For getting documents in failure store `GET\r\nlogs-*-*/_search?failure_store=only`\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5013a0af-fdfc-453a-b70c-fb2c452ad4d8","sha":"bf72e414206e7eafedb92b127df7f318604fc78e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[Dataset quality] Failure store support in synthtrace","number":195726,"url":"https://github.com/elastic/kibana/pull/195726","mergeCommit":{"message":"[Dataset quality] Failure store support in synthtrace (#195726)\n\nThis PR enables the creation of scenarios using failure store in\r\nsynthtrace.\r\n\r\n#### How to test?\r\n1. Run the scenario `node scripts/synthtrace failed_logs`\r\n2. Go to dev console\r\n- For getting documents ingested `GET logs-*-*/_search`. This is\r\nequivalent to `GET logs-*-*/_search?failure_store=exclude` and will only\r\ninclude the documents that were properly ingested.\r\n- For getting documents in failure store `GET\r\nlogs-*-*/_search?failure_store=only`\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5013a0af-fdfc-453a-b70c-fb2c452ad4d8","sha":"bf72e414206e7eafedb92b127df7f318604fc78e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195726","number":195726,"mergeCommit":{"message":"[Dataset quality] Failure store support in synthtrace (#195726)\n\nThis PR enables the creation of scenarios using failure store in\r\nsynthtrace.\r\n\r\n#### How to test?\r\n1. Run the scenario `node scripts/synthtrace failed_logs`\r\n2. Go to dev console\r\n- For getting documents ingested `GET logs-*-*/_search`. This is\r\nequivalent to `GET logs-*-*/_search?failure_store=exclude` and will only\r\ninclude the documents that were properly ingested.\r\n- For getting documents in failure store `GET\r\nlogs-*-*/_search?failure_store=only`\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5013a0af-fdfc-453a-b70c-fb2c452ad4d8","sha":"bf72e414206e7eafedb92b127df7f318604fc78e"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the creation of scenarios using failure store in synthtrace.
How to test?
node scripts/synthtrace failed_logsGET logs-*-*/_search. This is equivalent toGET logs-*-*/_search?failure_store=excludeand will only include the documents that were properly ingested.GET logs-*-*/_search?failure_store=onlyScreen.Recording.2024-10-10.at.11.33.45.mov