Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ES|QL] Present ES|QL as an equal to data views on the "no data views" screen (#194077) #195684

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…" screen (elastic#194077)

## Summary

Resolves elastic#176291

### Screenshots

#### Discover/Dashboard/Visualize
<img width="1517" alt="image"
src="https://github.com/user-attachments/assets/c8fb4faf-8d2d-4043-a757-6f092d1fceb3">

#### Stack Management > Data view
<img width="1519" alt="image"
src="https://github.com/user-attachments/assets/bb3f28bd-0ce9-4c49-ace1-1be875e17ba3">

#### If User does not have privilege to create a Data View
<img width="1336" alt="image"
src="https://github.com/user-attachments/assets/bb3f4cbc-8213-41c0-bf09-bd47a9d264e4">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Use a new SVG resource for the ES|QL illustration
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Andrea Del Rio <[email protected]>
(cherry picked from commit 56e1e68)
@kibanamachine kibanamachine merged commit ce302a9 into elastic:8.x Oct 9, 2024
28 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / Title it disables the input when loading

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 664 665 +1
dataViewManagement 239 240 +1
discover 992 993 +1
kibanaOverview 136 137 +1
lens 1461 1462 +1
visualizations 476 477 +1
total +6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/shared-ux-page-analytics-no-data-mocks 17 20 +3
@kbn/shared-ux-prompt-no-data-views-mocks 23 25 +2
total +5

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/shared-ux-prompt-no-data-views 0 1 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 626.5KB 627.5KB +1.1KB
dataViewManagement 142.4KB 137.1KB -5.3KB
discover 820.0KB 821.2KB +1.2KB
kibanaOverview 53.6KB 54.7KB +1.1KB
lens 1.5MB 1.5MB +851.0B
visualizations 315.5KB 316.6KB +1.1KB
total -85.0B
Unknown metric groups

API count

id before after diff
@kbn/shared-ux-page-analytics-no-data 19 20 +1
@kbn/shared-ux-page-analytics-no-data-mocks 17 21 +4
@kbn/shared-ux-prompt-no-data-views 34 36 +2
@kbn/shared-ux-prompt-no-data-views-mocks 24 26 +2
total +9

async chunk count

id before after diff
dashboard 15 14 -1
dataViewManagement 3 2 -1
discover 28 27 -1
kibanaOverview 3 2 -1
lens 24 23 -1
visualizations 16 15 -1
total -6

miscellaneous assets size

id before after diff
dashboard 838.8KB 1.4MB ⚠️ +621.5KB
dataViewManagement 226.3KB 847.7KB ⚠️ +621.5KB
discover 226.3KB 847.7KB ⚠️ +621.5KB
kibanaOverview 226.3KB 847.7KB ⚠️ +621.5KB
lens 310.2KB 931.7KB ⚠️ +621.5KB
visualizations 451.8KB 1.0MB ⚠️ +621.5KB
total ⚠️ +3.6MB

cc @tsullivan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants