[ES|QL] only suggest pipe at the end of the field list #195679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
added
the
backport:prev-minor
drewdaemon
added
release_note:fix
Feature:ES|QL
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
## Summary Close elastic#191100 ### Improvements 1. You no longer get a comma suggestion when you're out of fields... https://github.com/user-attachments/assets/3ed3617b-99e2-44a5-917e-294b98f16ef4 2. Fixed elastic#191100 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit dffe0b5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
#195798) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] only suggest pipe at the end of the field list (#195679)](#195679) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T15:33:55Z","message":"[ES|QL] only suggest pipe at the end of the field list (#195679)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/191100\r\n\r\n### Improvements\r\n\r\n1. You no longer get a comma suggestion when you're out of fields...\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3ed3617b-99e2-44a5-917e-294b98f16ef4\r\n\r\n2. Fixed https://github.com/elastic/kibana/issues/191100\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"dffe0b571899b2ed0c71ee9f090095311d4d2b55","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL"],"title":"[ES|QL] only suggest pipe at the end of the field list","number":195679,"url":"https://github.com/elastic/kibana/pull/195679","mergeCommit":{"message":"[ES|QL] only suggest pipe at the end of the field list (#195679)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/191100\r\n\r\n### Improvements\r\n\r\n1. You no longer get a comma suggestion when you're out of fields...\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3ed3617b-99e2-44a5-917e-294b98f16ef4\r\n\r\n2. Fixed https://github.com/elastic/kibana/issues/191100\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"dffe0b571899b2ed0c71ee9f090095311d4d2b55"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195679","number":195679,"mergeCommit":{"message":"[ES|QL] only suggest pipe at the end of the field list (#195679)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/191100\r\n\r\n### Improvements\r\n\r\n1. You no longer get a comma suggestion when you're out of fields...\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3ed3617b-99e2-44a5-917e-294b98f16ef4\r\n\r\n2. Fixed https://github.com/elastic/kibana/issues/191100\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"dffe0b571899b2ed0c71ee9f090095311d4d2b55"}}]}] BACKPORT--> Co-authored-by: Drew Tate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #191100
Improvements
Screen.Recording.2024-10-09.at.2.04.29.PM.mov
Checklist