[Related alerts] Add related alerts for all the observability rules #195592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
release_note:skip
maryam-saeidi
commented
Oct 10, 2024
| @@ -79,6 +101,8 @@ export function InternalRelatedAlerts({ alert, kuery }: Props) { | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| }, [alertStart, alertEnd]); | |||
|
|
|||
| if (!kuery || !alert) return <EmptyState />; | |||
There was a problem hiding this comment.
This should never happen because we have filter based on rule id in the kuery, but I just added it in case there was a bug or something went wrong.
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsmiscellaneous assets size
History
|
shahzad31
reviewed
Oct 15, 2024
| // - location | ||
| export const OBSERVER_NAME = 'observer.name'; | ||
| // Inventory rule | ||
| export const HOST = 'host.name'; |
There was a problem hiding this comment.
would host.ip also make sense here?
There was a problem hiding this comment.
Maybe, I need to check a bit more to see if this field is useful for most of the scenarios or not. (Added a new tab to this spreadsheet, "other fields" tab, feel free to add more fields that you think might be useful)
I started with a small set of fields, and we can extend it in the future.
benakansara
approved these changes
Oct 15, 2024
Comment on lines
+27
to
+39
| export const SERVICE_NAME = 'service.name'; | ||
| // Synthetics rules | ||
| export const MONITOR_ID = 'monitor.id'; | ||
| // - location | ||
| export const OBSERVER_NAME = 'observer.name'; | ||
| // Inventory rule | ||
| export const HOST = 'host.name'; | ||
| export const KUBERNETES_POD = 'kubernetes.pod.uid'; | ||
| export const DOCKER_CONTAINER = 'container.id'; | ||
| export const EC2_INSTANCE = 'cloud.instance.id'; | ||
| export const S3_BUCKETS = 'aws.s3.bucket.name'; | ||
| export const RDS_DATABASES = 'aws.rds.db_instance.arn'; | ||
| export const SQS_QUEUES = 'aws.sqs.queue.name'; |
There was a problem hiding this comment.
We have some of these defined here as well. Could we move it to a common file and use it from there in both places?
There was a problem hiding this comment.
Yeah, sure. I will do it in a follow-up PR.
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
…lastic#195592) Closes elastic#193942 Closes elastic#193952 ## Summary This PR adds related alert logic for all the observability rules, as mentioned in elastic#193942. Also, it adds a beta badge for this new tab.  (cherry picked from commit b4c3ab5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
…ules (#195592) (#196437) # Backport This will backport the following commits from `main` to `8.x`: - [[Related alerts] Add related alerts for all the observability rules (#195592)](#195592) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T20:05:11Z","message":"[Related alerts] Add related alerts for all the observability rules (#195592)\n\nCloses #193942\r\nCloses #193952\r\n\r\n## Summary\r\n\r\nThis PR adds related alert logic for all the observability rules, as\r\nmentioned in #193942. Also, it adds a beta badge for this new tab.\r\n\r\n\r\n","sha":"b4c3ab55a0680db2ec1a9d2f01051266f599e172","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Related alerts] Add related alerts for all the observability rules","number":195592,"url":"https://github.com/elastic/kibana/pull/195592","mergeCommit":{"message":"[Related alerts] Add related alerts for all the observability rules (#195592)\n\nCloses #193942\r\nCloses #193952\r\n\r\n## Summary\r\n\r\nThis PR adds related alert logic for all the observability rules, as\r\nmentioned in #193942. Also, it adds a beta badge for this new tab.\r\n\r\n\r\n","sha":"b4c3ab55a0680db2ec1a9d2f01051266f599e172"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195592","number":195592,"mergeCommit":{"message":"[Related alerts] Add related alerts for all the observability rules (#195592)\n\nCloses #193942\r\nCloses #193952\r\n\r\n## Summary\r\n\r\nThis PR adds related alert logic for all the observability rules, as\r\nmentioned in #193942. Also, it adds a beta badge for this new tab.\r\n\r\n\r\n","sha":"b4c3ab55a0680db2ec1a9d2f01051266f599e172"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193942
Closes #193952
Summary
This PR adds related alert logic for all the observability rules, as mentioned in #193942. Also, it adds a beta badge for this new tab.