[ES|QL] [Discover] Keeps the preferred chart type when possible

[stratoula]

Summary

Part of #184631

It keeps the chart type when the user is doing actions compatible with the current query such as:

• Adding a where filter (by clicking the table, the sidebar, the chart)
• Changes the breakdown field and the field type is compatible with the current chart
• Removing a dimension

The logic depends on the suggestions. If the suggestions return the preferred chart type, then we are going to use this. So it really depends on the api and the type of columns.

Important note

This doesnt keep all the vis changes, only the chart type

Checklist

• Unit or functional tests were updated or added to match the most common scenarios
• Flaky Test Runner was used on any tests changed

[stratoula]

ℹ️ Moving this here for reusability

[kibanamachine]

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7219

[✅] test/functional/apps/discover/esql/config.ts: 25/25 tests passed.

see run history

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[elasticmachine]

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

• Click to trigger kibana-pull-request for this PR!
• Click to trigger kibana-deploy-project-from-pr for this PR!

[stratoula]

Sorry for the ping, do not review yet, I found a small bug

[elasticmachine]

💔 Build Failed

• Buildkite Build
• Commit: 810bc19

Failed CI Steps

• Jest Integration Tests #2
• Jest Integration Tests #2

Test Failures

• [job] [logs] Jest Integration Tests #2 / incompatible_cluster_routing_allocation retries the INIT action with a descriptive message when cluster settings are incompatible
• [job] [logs] Jest Integration Tests #2 / incompatible_cluster_routing_allocation retries the INIT action with a descriptive message when cluster settings are incompatible

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
aiops	583	584	+1
apm	1880	1881	+1
charts	126	127	+1
cloudSecurityPosture	655	656	+1
dashboard	674	675	+1
dataVisualizer	728	729	+1
discover	994	995	+1
esqlDataGrid	364	365	+1
eventAnnotationListing	579	580	+1
expressionHeatmap	178	179	+1
expressionMetricVis	112	113	+1
expressionPartitionVis	193	194	+1
expressionTagcloud	167	168	+1
expressionXY	254	255	+1
graph	300	301	+1
investigateApp	579	580	+1
lens	1466	1467	+1
logsExplorer	564	565	+1
ml	2036	2037	+1
observability	1063	1064	+1
observabilityAIAssistantApp	381	382	+1
securitySolution	6037	6038	+1
slo	848	849	+1
transform	504	505	+1
triggersActionsUi	850	851	+1
unifiedHistogram	186	188	+2
visDefaultEditor	203	204	+1
visTypeTimelion	63	64	+1
visTypeTimeseries	459	460	+1
total			+30

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/visualization-utils	17	18	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.5MB	1.5MB	-196.0B
observabilityAIAssistantApp	238.7KB	238.7KB	-9.0B
unifiedHistogram	70.1KB	70.6KB	+516.0B
total			+311.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
lens	62	61	-1

Unknown metric groups

API count

id	before	after	diff
@kbn/visualization-utils	19	20	+1

History

• 💚 Build #243803 succeeded 6ba9ae5
• 💔 Build #243741 failed a391020

[stratoula]

Closing in favor of #197453