Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto Import] Add run names to LangSmith traces #195576

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[Auto Import] Add run names to LangSmith traces #195576

merged 2 commits into from
Oct 9, 2024

Conversation

ilyannn
Copy link
Contributor

@ilyannn ilyannn commented Oct 9, 2024 •
edited by kibanamachine
Loading

Summary

Adds a name wherever a LangSmith graph is compiled. This allows us to review the traces faster:

image

Testing

Generated: ai_teleport_202410091437-1.0.0.zip

@ilyannn ilyannn added release_note:skip Skip the PR/issue when compiling release notes backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Team:Security-Scalability Team label for Security Integrations Scalability Team Feature:AutomaticImport labels Oct 9, 2024
@ilyannn ilyannn self-assigned this Oct 9, 2024
@ilyannn ilyannn marked this pull request as ready for review October 9, 2024 11:43
@ilyannn ilyannn requested a review from a team as a code owner October 9, 2024 11:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@ilyannn ilyannn enabled auto-merge (squash) October 9, 2024 11:43
@ilyannn ilyannn mentioned this pull request Oct 9, 2024
Closed
2 tasks
@kgeller
Copy link
Contributor

kgeller commented Oct 9, 2024

@ilyannn do you think it'd be worth prefixing these names with 'Automatic Import' ie Automatic Import : ECS Mapping?

Obviously we know what they are, but theoretically a user could enable the traces and maybe want a more explicit name?

bhapas
bhapas approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. LGTM

@ilyannn
Copy link
Contributor Author

ilyannn commented Oct 9, 2024 •
edited
Loading

@ilyannn do you think it'd be worth prefixing these names with 'Automatic Import' ie Automatic Import : ECS Mapping?

Obviously we know what they are, but theoretically a user could enable the traces and maybe want a more explicit name?

That would reduce the readability back, as we'll only see 'Automatic...' instead of the full name, I think. But there is some other metadata we can research and include. Best to check what the other assistants do first.

@ilyannn ilyannn merged commit e366c0a into elastic:main Oct 9, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11256393504

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @ilyannn

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@ilyannn
[Auto Import] Add run names to LangSmith traces (elastic#195576)
65a5e85 
## Summary

Adds a name wherever a LangSmith graph is compiled.
This allows us to review the traces faster.

(cherry picked from commit e366c0a)
@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@ilyannn
[Auto Import] Add run names to LangSmith traces (elastic#195576)
af758a6 
## Summary

Adds a name wherever a LangSmith graph is compiled.
This allows us to review the traces faster.

(cherry picked from commit e366c0a)
@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @ilyannn
[8.x] [Auto Import] Add run names to LangSmith traces (#195576) (#195604
062ea57 
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Auto Import] Add run names to LangSmith traces
(#195576)](#195576)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ilya
Nikokoshev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T13:49:59Z","message":"[Auto
Import] Add run names to LangSmith traces (#195576)\n\n##
Summary\r\n\r\nAdds a name wherever a LangSmith graph is compiled.
\r\nThis allows us to review the traces
faster.","sha":"e366c0ae7cbe094fc3363b6b0fa152575958346c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Auto
Import] Add run names to LangSmith
traces","number":195576,"url":"https://github.com/elastic/kibana/pull/195576","mergeCommit":{"message":"[Auto
Import] Add run names to LangSmith traces (#195576)\n\n##
Summary\r\n\r\nAdds a name wherever a LangSmith graph is compiled.
\r\nThis allows us to review the traces
faster.","sha":"e366c0ae7cbe094fc3363b6b0fa152575958346c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195576","number":195576,"mergeCommit":{"message":"[Auto
Import] Add run names to LangSmith traces (#195576)\n\n##
Summary\r\n\r\nAdds a name wherever a LangSmith graph is compiled.
\r\nThis allows us to review the traces
faster.","sha":"e366c0ae7cbe094fc3363b6b0fa152575958346c"}}]}]
BACKPORT-->

Co-authored-by: Ilya Nikokoshev <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @ilyannn
[8.15] [Auto Import] Add run names to LangSmith traces (#195576) (#19…
daefd92 
…5603)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Auto Import] Add run names to LangSmith traces
(#195576)](#195576)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ilya
Nikokoshev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T13:49:59Z","message":"[Auto
Import] Add run names to LangSmith traces (#195576)\n\n##
Summary\r\n\r\nAdds a name wherever a LangSmith graph is compiled.
\r\nThis allows us to review the traces
faster.","sha":"e366c0ae7cbe094fc3363b6b0fa152575958346c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Auto
Import] Add run names to LangSmith
traces","number":195576,"url":"https://github.com/elastic/kibana/pull/195576","mergeCommit":{"message":"[Auto
Import] Add run names to LangSmith traces (#195576)\n\n##
Summary\r\n\r\nAdds a name wherever a LangSmith graph is compiled.
\r\nThis allows us to review the traces
faster.","sha":"e366c0ae7cbe094fc3363b6b0fa152575958346c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195576","number":195576,"mergeCommit":{"message":"[Auto
Import] Add run names to LangSmith traces (#195576)\n\n##
Summary\r\n\r\nAdds a name wherever a LangSmith graph is compiled.
\r\nThis allows us to review the traces
faster.","sha":"e366c0ae7cbe094fc3363b6b0fa152575958346c"}}]}]
BACKPORT-->

Co-authored-by: Ilya Nikokoshev <[email protected]>
@mistic
Copy link
Member

mistic commented Oct 17, 2024

This PR didn't make it into the latest BC of v8.15.3. Updating the labels.

@mistic mistic added v8.15.4 and removed v8.15.3 labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

@kgeller kgeller kgeller approved these changes

Assignees

@ilyannn ilyannn

Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Feature:AutomaticImport release_note:skip Skip the PR/issue when compiling release notes Team:Security-Scalability Team label for Security Integrations Scalability Team v8.15.4 v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilyannn @elasticmachine @kgeller @kibanamachine @mistic @bhapas