Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataView] show empty matching sources when no matched index pattern #195537

Merged
merged 14 commits into from
Oct 24, 2024
Merged

[DataView] show empty matching sources when no matched index pattern #195537

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6af9e25
[DataView] show empty matching sources when no matched index pattern
lsq645599166 Oct 9, 2024
1d447d2
Merge branch 'main' into data_view_index_no_matched
kertal Oct 9, 2024
c6b9cd3
[DataView] redirect to all Sources when no matched index
lsq645599166 Oct 12, 2024
1d8a8d5
[DataView] fix unit test
lsq645599166 Oct 12, 2024
010d44b
Merge branch 'main' into data_view_index_no_matched
elasticmachine Oct 14, 2024
9da2b78
Merge branch 'main' into data_view_index_no_matched
elasticmachine Oct 16, 2024
46098e3
[DataView] add no matched helper text
lsq645599166 Oct 18, 2024
eabcd08
Merge branch 'main' into data_view_index_no_matched
elasticmachine Oct 18, 2024
dc193e9
[DataView] hide tab when no matched index
lsq645599166 Oct 19, 2024
6f820db
Merge branch 'main' into data_view_index_no_matched
elasticmachine Oct 19, 2024
a157db9
Merge branch 'main' into data_view_index_no_matched
davismcphee Oct 21, 2024
7ff4950
[Dataview] revert getMatchedIndices
lsq645599166 Oct 23, 2024
0b27ea4
Merge branch 'main' into data_view_index_no_matched
elasticmachine Oct 23, 2024
fb3add3
Merge branch 'main' into data_view_index_no_matched
davismcphee Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/plugins/data_view_editor/public/components/preview_panel/preview_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,18 @@ export const PreviewPanel = ({ type, allowHidden, title = '', matchedIndices$ }:
query={title}
/>
<EuiSpacer size="m" />
{Boolean(title) && currentlyVisibleIndices.length > 0 && (
<EuiButtonGroup
isFullWidth
legend={i18n.translate('indexPatternEditor.previewPanel.viewModeGroup.legend', {
defaultMessage: 'Visible sources',
})}
options={viewModeButtons}
idSelected={currentViewMode}
onChange={(id: string) => setViewMode(id as ViewMode)}
/>
)}
{Boolean(title) &&
(matched.exactMatchedIndices.length > 0 || matched.partialMatchedIndices.length > 0) && (
<EuiButtonGroup
isFullWidth
legend={i18n.translate('indexPatternEditor.previewPanel.viewModeGroup.legend', {
defaultMessage: 'Visible sources',
})}
options={viewModeButtons}
idSelected={currentViewMode}
onChange={(id: string) => setViewMode(id as ViewMode)}
/>
)}
{indicesListContent}
</>
);
Expand Down